Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7544)

Unified Diff: chrome/browser/sync_file_system/drive_file_sync_service.cc

Issue 15657002: Mirror syncfs log to console and WebUI, with LogSeverity support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_file_sync_service.cc
diff --git a/chrome/browser/sync_file_system/drive_file_sync_service.cc b/chrome/browser/sync_file_system/drive_file_sync_service.cc
index 967d83349bdd2e849f5d185176bb40e86ec16f07..aadfb321b26254c1a0cf847fcdd8a7b665efe2b3 100644
--- a/chrome/browser/sync_file_system/drive_file_sync_service.cc
+++ b/chrome/browser/sync_file_system/drive_file_sync_service.cc
@@ -1452,7 +1452,8 @@ void DriveFileSyncService::MaybeStartFetchChanges() {
}
void DriveFileSyncService::OnNotificationReceived() {
- util::Log("Notification received to check for Google Drive updates");
+ util::Log(logging::LOG_INFO,
+ "Notification received to check for Google Drive updates");
// TODO(calvinlo): Try to eliminate may_have_unfetched_changes_ variable.
may_have_unfetched_changes_ = true;
MaybeStartFetchChanges();
@@ -1460,7 +1461,7 @@ void DriveFileSyncService::OnNotificationReceived() {
void DriveFileSyncService::OnPushNotificationEnabled(bool enabled) {
const char* status = (enabled ? "enabled" : "disabled");
- util::Log("XMPP Push notification is %s", status);
+ util::Log(logging::LOG_INFO, "XMPP Push notification is %s", status);
}
void DriveFileSyncService::MaybeScheduleNextTask() {
@@ -1582,12 +1583,14 @@ void DriveFileSyncService::DidFetchChangesForIncrementalSync(
}
if (reset_sync_root) {
- LOG(WARNING) << "Detected unexpected SyncRoot deletion.";
+ util::Log(logging::LOG_WARNING, "Detected unexpected SyncRoot deletion.");
metadata_store_->SetSyncRootDirectory(std::string());
}
for (std::set<GURL>::iterator itr = reset_origins.begin();
itr != reset_origins.end(); ++itr) {
- LOG(WARNING) << "Detected unexpected OriginRoot deletion:" << itr->spec();
+ util::Log(logging::LOG_WARNING,
+ std::string("Detected unexpected OriginRoot deletion:").append(
nhiroki 2013/05/22 05:42:40 nit: I'd prefer to use operator+() instead of appe
calvinlo 2013/05/22 08:42:56 I forgot this logging statement is like printf and
+ itr->spec()));
pending_batch_sync_origins_.erase(*itr);
metadata_store_->SetOriginRootDirectory(*itr, std::string());
}

Powered by Google App Engine
This is Rietveld 408576698