Mirror syncfs log to console and WebUI, with LogSeverity support.

chrome/browser/sync_file_system/drive_file_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_file_sync_service.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
@@ skipping 1434 matching lines @@
 
   if (may_have_unfetched_changes_ &&
       !metadata_store_->incremental_sync_origins().empty()) {
     task_manager_->ScheduleTaskIfIdle(
         base::Bind(&DriveFileSyncService::FetchChangesForIncrementalSync,
                    AsWeakPtr()));
   }
 }
 
 void DriveFileSyncService::OnNotificationReceived() {
-  util::Log("Notification received to check for Google Drive updates");
+  util::Log(logging::LOG_INFO,
+            "Notification received to check for Google Drive updates");
   // TODO(calvinlo): Try to eliminate may_have_unfetched_changes_ variable.
   may_have_unfetched_changes_ = true;
   MaybeStartFetchChanges();
 }
 
 void DriveFileSyncService::OnPushNotificationEnabled(bool enabled) {
   const char* status = (enabled ? "enabled" : "disabled");
-  util::Log("XMPP Push notification is %s", status);
+  util::Log(logging::LOG_INFO, "XMPP Push notification is %s", status);
 }
 
 void DriveFileSyncService::MaybeScheduleNextTask() {
   if (GetCurrentState() == REMOTE_SERVICE_DISABLED)
     return;
 
   // Notify observer of the update of |pending_changes_|.
   FOR_EACH_OBSERVER(Observer, service_observers_,
                     OnRemoteChangeQueueUpdated(
                         remote_change_handler_.ChangesSize()));
@@ skipping 101 matching lines @@
 
     DVLOG(3) << " * change:" << entry.title()
              << (entry.deleted() ? " (deleted)" : " ")
              << "[" << origin.spec() << "]";
     has_new_changes = AppendRemoteChange(
         origin, entry, entry.changestamp(),
         RemoteChangeHandler::REMOTE_SYNC_TYPE_INCREMENTAL) || has_new_changes;
   }
 
   if (reset_sync_root) {
-    LOG(WARNING) << "Detected unexpected SyncRoot deletion.";
+    util::Log(logging::LOG_WARNING, "Detected unexpected SyncRoot deletion.");
     metadata_store_->SetSyncRootDirectory(std::string());
   }
   for (std::set<GURL>::iterator itr = reset_origins.begin();
        itr != reset_origins.end(); ++itr) {
-    LOG(WARNING) << "Detected unexpected OriginRoot deletion:" << itr->spec();
+    util::Log(logging::LOG_WARNING,
+              std::string("Detected unexpected OriginRoot deletion:").append(

[nhiroki, 2013/05/22 05:42:40]

nit: I'd prefer to use operator+() instead of append() here and elsewhere.

[calvinlo, 2013/05/22 08:42:56]

I forgot this logging statement is like printf and I can give variable number of
params. So I can use %s in the format string and just get rid of all the
appends.

+                  itr->spec()));
     pending_batch_sync_origins_.erase(*itr);
     metadata_store_->SetOriginRootDirectory(*itr, std::string());
   }
 
   GURL next_feed;
   if (changes->GetNextFeedURL(&next_feed))
     may_have_unfetched_changes_ = true;
 
   if (!changes->entries().empty())
     largest_fetched_changestamp_ = changes->entries().back()->changestamp();
@@ skipping 111 matching lines @@
       pending_batch_sync_origins_.insert(origin);
   }
   callback.Run(status, resource_id);
 }
 
 std::string DriveFileSyncService::sync_root_resource_id() {
   return metadata_store_->sync_root_directory();
 }
 
 }  // namespace sync_file_system