Eliminate constructor return types from summaries.

Eliminate constructor return types from summaries.

These can be easily inferred at the time the summary is resynthesized
into an element model.  This should make the summary size marginally
smaller, and make it easier to create summaries straight from the AST.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d470281376e64c369607540352683d2f5b4de00

[Paul Berry, 2016-01-06 02:18:12]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[Paul Berry, 2016-01-06 02:18:13]

https://codereview.chromium.org/1565643002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_test.dart (right):

https://codereview.chromium.org/1565643002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_test.dart:2191:
checkTypeRef(unlinkedUnits[0].variables.single.type, null, null, 'C',
Note that this test was completely bogus--it was checking that the return type
of class C's constructor properly referred to class C.  I've changed it to match
the intention, which was to check that the declaration of variable c in the
defining compilation unit properly refers to class C.

[scheglov, 2016-01-06 02:26:21]

LGTM

[Paul Berry, 2016-01-06 14:48:01]

Description was changed from

==========
Eliminate constructor return types from summaries.

These can be easily inferred at the time the summary is resynthesized
into an element model.  This should make the summary size marginally
smaller, and make it easier to create summaries straight from the AST.
==========

to

==========
Eliminate constructor return types from summaries.

These can be easily inferred at the time the summary is resynthesized
into an element model.  This should make the summary size marginally
smaller, and make it easier to create summaries straight from the AST.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5d470281376e64c369607540352683d2f5b4de00
==========

[Paul Berry, 2016-01-06 14:48:03]

Committed patchset #1 (id:1) manually as
5d470281376e64c369607540352683d2f5b4de00 (presubmit successful).