pkg/analyzer/lib/src/summary/summarize_elements.dart - Issue 1565643002: Eliminate constructor return types from summaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summarize_elements.dart

Issue 1565643002: Eliminate constructor return types from summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/summary/summarize_elements.dart

diff --git a/pkg/analyzer/lib/src/summary/summarize_elements.dart b/pkg/analyzer/lib/src/summary/summarize_elements.dart

index eddb78ca9088eb322f356bb6ec8af367cdc712cf..e28319a9aae8e89721eb70ef55394c881bdaed23 100644

--- a/pkg/analyzer/lib/src/summary/summarize_elements.dart

+++ b/pkg/analyzer/lib/src/summary/summarize_elements.dart

@@ -393,7 +393,8 @@ class _LibrarySerializer {

ExecutableElement executableElement) {

UnlinkedExecutableBuilder b = new UnlinkedExecutableBuilder(ctx);

b.name = executableElement.name;

- if (!executableElement.type.returnType.isVoid) {

+ if (executableElement is! ConstructorElement &&

+ !executableElement.type.returnType.isVoid) {

b.returnType = serializeTypeRef(

executableElement.type.returnType, executableElement);

}