Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: media/cast/net/udp_transport.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/net/udp_transport.cc
diff --git a/media/cast/net/udp_transport.cc b/media/cast/net/udp_transport.cc
index 97ec7f4aaeec529dd1e605ce767f5e371bb2784f..a909e21b76c39bd494f3a00a68ffb6ffc8f3f685 100644
--- a/media/cast/net/udp_transport.cc
+++ b/media/cast/net/udp_transport.cc
@@ -24,16 +24,17 @@ namespace {
const int kMaxPacketSize = 1500;
bool IsEmpty(const net::IPEndPoint& addr) {
- net::IPAddressNumber empty_addr(addr.address().size());
- return std::equal(
- empty_addr.begin(), empty_addr.end(), addr.address().begin()) &&
+ net::IPAddressNumber empty_addr(addr.address_number().size());
+ return std::equal(empty_addr.begin(), empty_addr.end(),
eroman 2016/01/13 00:27:57 I have seen this pattern in some other places. Mig
+ addr.address_number().begin()) &&
!addr.port();
}
bool IsEqual(const net::IPEndPoint& addr1, const net::IPEndPoint& addr2) {
- return addr1.port() == addr2.port() && std::equal(addr1.address().begin(),
- addr1.address().end(),
- addr2.address().begin());
+ return addr1.port() == addr2.port() &&
+ std::equal(addr1.address_number().begin(),
eroman 2016/01/13 00:27:57 Hmm, this looks wrong. Filed https://code.google.c
+ addr1.address_number().end(),
+ addr2.address_number().begin());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698