Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: content/browser/renderer_host/pepper/pepper_socket_utils.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/pepper/pepper_socket_utils.cc
diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.cc b/content/browser/renderer_host/pepper/pepper_socket_utils.cc
index c421fe29f70c602407cd1711afded5bceb280d1f..d84cb614e79adf8f31dd93cdb772f703fe0135b2 100644
--- a/content/browser/renderer_host/pepper/pepper_socket_utils.cc
+++ b/content/browser/renderer_host/pepper/pepper_socket_utils.cc
@@ -181,11 +181,12 @@ std::string addressToFirewallString(const net::IPAddressNumber& address) {
void OpenFirewallHole(const net::IPEndPoint& address,
chromeos::FirewallHole::PortType type,
FirewallHoleOpenCallback callback) {
- if (isLoopbackAddress(address.address())) {
+ if (isLoopbackAddress(address.address_number())) {
eroman 2016/01/13 00:27:57 (aside) Looks like these existing functions are in
martijnc 2016/01/13 22:49:31 (will fix that in separate CL)
callback.Run(nullptr);
return;
}
- std::string address_string = addressToFirewallString(address.address());
+ std::string address_string =
+ addressToFirewallString(address.address_number());
chromeos::FirewallHole::Open(type, address.port(), address_string, callback);
}

Powered by Google App Engine
This is Rietveld 408576698