Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback eroman Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 4e30c39a3f6aafddfcbe5f36e7dfd69a87b1c96d..88d4482aaa785035190bf2cd129b0d26c3d2e956 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -409,8 +409,8 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
server_thread_->server()->SetChloMultiplier(chlo_multiplier_);
}
server_thread_->Initialize();
- server_address_ =
- IPEndPoint(server_address_.address(), server_thread_->GetPort());
+ server_address_ = IPEndPoint(server_address_.address().bytes(),
+ server_thread_->GetPort());
QuicDispatcher* dispatcher =
QuicServerPeer::GetDispatcher(server_thread_->server());
TestWriterFactory* packet_writer_factory = new TestWriterFactory();
@@ -1469,7 +1469,7 @@ class WrongAddressWriter : public QuicPacketWriterWrapper {
const IPEndPoint& peer_address) override {
// Use wrong address!
return QuicPacketWriterWrapper::WritePacket(
- buffer, buf_len, self_address_.address(), peer_address);
+ buffer, buf_len, self_address_.address().bytes(), peer_address);
}
bool IsWriteBlockedDataBuffered() const override { return false; }
@@ -1484,7 +1484,8 @@ TEST_P(EndToEndTest, ConnectionMigrationClientIPChanged) {
EXPECT_EQ(200u, client_->response_headers()->parsed_response_code());
// Store the client IP address which was used to send the first request.
- IPAddressNumber old_host = client_->client()->client_address().address();
+ IPAddressNumber old_host =
+ client_->client()->client_address().address().bytes();
// Migrate socket to the new IP address.
IPAddressNumber new_host;
@@ -1528,11 +1529,14 @@ TEST_P(EndToEndTest, ConnectionMigrationClientPortChanged) {
// FD rather than any more complex NAT rebinding simulation.
int new_port = client_->client()->client_address().port();
QuicClientPeer::SetClientPort(client_->client(), new_port);
- QuicConnectionPeer::SetSelfAddress(
- client_->client()->session()->connection(),
- IPEndPoint(
- client_->client()->session()->connection()->self_address().address(),
- new_port));
+ QuicConnectionPeer::SetSelfAddress(client_->client()->session()->connection(),
+ IPEndPoint(client_->client()
+ ->session()
+ ->connection()
+ ->self_address()
+ .address()
+ .bytes(),
+ new_port));
// Register the new FD for epoll events.
int new_fd = client_->client()->fd();
@@ -1808,7 +1812,7 @@ TEST_P(EndToEndTest, ServerSendPublicResetWithDifferentConnectionId) {
// race conditions.
server_thread_->Pause();
server_writer_->WritePacket(packet->data(), packet->length(),
- server_address_.address(),
+ server_address_.address().bytes(),
client_->client()->client_address());
server_thread_->Resume();
@@ -1835,9 +1839,9 @@ TEST_P(EndToEndTest, ClientSendPublicResetWithDifferentConnectionId) {
QuicFramer framer(server_supported_versions_, QuicTime::Zero(),
Perspective::IS_CLIENT);
scoped_ptr<QuicEncryptedPacket> packet(framer.BuildPublicResetPacket(header));
- client_writer_->WritePacket(packet->data(), packet->length(),
- client_->client()->client_address().address(),
- server_address_);
+ client_writer_->WritePacket(
+ packet->data(), packet->length(),
+ client_->client()->client_address().address().bytes(), server_address_);
// The connection should be unaffected.
EXPECT_EQ(kFooResponseBody, client_->SendSynchronousRequest("/foo"));
@@ -1863,7 +1867,7 @@ TEST_P(EndToEndTest, ServerSendVersionNegotiationWithDifferentConnectionId) {
// race conditions.
server_thread_->Pause();
server_writer_->WritePacket(packet->data(), packet->length(),
- server_address_.address(),
+ server_address_.address().bytes(),
client_->client()->client_address());
server_thread_->Resume();
@@ -1888,9 +1892,9 @@ TEST_P(EndToEndTest, BadPacketHeaderTruncated) {
0x3C,
// truncated connection ID
0x11};
- client_writer_->WritePacket(&packet[0], sizeof(packet),
- client_->client()->client_address().address(),
- server_address_);
+ client_writer_->WritePacket(
+ &packet[0], sizeof(packet),
+ client_->client()->client_address().address().bytes(), server_address_);
// Give the server time to process the packet.
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
// Pause the server so we can access the server's internals without races.
@@ -1926,9 +1930,9 @@ TEST_P(EndToEndTest, BadPacketHeaderFlags) {
// private flags
0x00,
};
- client_writer_->WritePacket(&packet[0], sizeof(packet),
- client_->client()->client_address().address(),
- server_address_);
+ client_writer_->WritePacket(
+ &packet[0], sizeof(packet),
+ client_->client()->client_address().address().bytes(), server_address_);
// Give the server time to process the packet.
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
// Pause the server so we can access the server's internals without races.
@@ -1961,9 +1965,9 @@ TEST_P(EndToEndTest, BadEncryptedData) {
string damaged_packet(packet->data(), packet->length());
damaged_packet[30] ^= 0x01;
DVLOG(1) << "Sending bad packet.";
- client_writer_->WritePacket(damaged_packet.data(), damaged_packet.length(),
- client_->client()->client_address().address(),
- server_address_);
+ client_writer_->WritePacket(
+ damaged_packet.data(), damaged_packet.length(),
+ client_->client()->client_address().address().bytes(), server_address_);
// Give the server time to process the packet.
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
// This error is sent to the connection's OnError (which ignores it), so the

Powered by Google App Engine
This is Rietveld 408576698