Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1909)

Unified Diff: net/socket/transport_client_socket_pool_unittest.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback eroman Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/transport_client_socket_pool_unittest.cc
diff --git a/net/socket/transport_client_socket_pool_unittest.cc b/net/socket/transport_client_socket_pool_unittest.cc
index dab0d07639801249daa4b4d321268361024dfb16..c42dd17a8a84e170d0733a82a3eef4849a26df42 100644
--- a/net/socket/transport_client_socket_pool_unittest.cc
+++ b/net/socket/transport_client_socket_pool_unittest.cc
@@ -874,14 +874,14 @@ TEST_F(TransportClientSocketPoolTest, IPv6FallbackSocketIPv4FinishesFirst) {
EXPECT_TRUE(handle.socket());
IPEndPoint endpoint;
handle.socket()->GetLocalAddress(&endpoint);
- EXPECT_EQ(kIPv4AddressSize, endpoint.address().size());
+ EXPECT_EQ(kIPv4AddressSize, endpoint.address().bytes().size());
// Check that the failed connection attempt on the main socket is collected.
ConnectionAttempts attempts;
handle.socket()->GetConnectionAttempts(&attempts);
ASSERT_EQ(1u, attempts.size());
EXPECT_EQ(ERR_CONNECTION_FAILED, attempts[0].result);
- EXPECT_EQ(kIPv6AddressSize, attempts[0].endpoint.address().size());
+ EXPECT_EQ(kIPv6AddressSize, attempts[0].endpoint.address().bytes().size());
EXPECT_EQ(2, client_socket_factory_.allocation_count());
}
@@ -926,7 +926,7 @@ TEST_F(TransportClientSocketPoolTest, IPv6FallbackSocketIPv6FinishesFirst) {
EXPECT_TRUE(handle.socket());
IPEndPoint endpoint;
handle.socket()->GetLocalAddress(&endpoint);
- EXPECT_EQ(kIPv6AddressSize, endpoint.address().size());
+ EXPECT_EQ(kIPv6AddressSize, endpoint.address().bytes().size());
// Check that the failed connection attempt on the fallback socket is
// collected.
@@ -934,7 +934,7 @@ TEST_F(TransportClientSocketPoolTest, IPv6FallbackSocketIPv6FinishesFirst) {
handle.socket()->GetConnectionAttempts(&attempts);
ASSERT_EQ(1u, attempts.size());
EXPECT_EQ(ERR_CONNECTION_FAILED, attempts[0].result);
- EXPECT_EQ(kIPv4AddressSize, attempts[0].endpoint.address().size());
+ EXPECT_EQ(kIPv4AddressSize, attempts[0].endpoint.address().bytes().size());
EXPECT_EQ(2, client_socket_factory_.allocation_count());
}
@@ -968,7 +968,7 @@ TEST_F(TransportClientSocketPoolTest, IPv6NoIPv4AddressesToFallbackTo) {
EXPECT_TRUE(handle.socket());
IPEndPoint endpoint;
handle.socket()->GetLocalAddress(&endpoint);
- EXPECT_EQ(kIPv6AddressSize, endpoint.address().size());
+ EXPECT_EQ(kIPv6AddressSize, endpoint.address().bytes().size());
EXPECT_EQ(0u, handle.connection_attempts().size());
EXPECT_EQ(1, client_socket_factory_.allocation_count());
}
@@ -1001,7 +1001,7 @@ TEST_F(TransportClientSocketPoolTest, IPv4HasNoFallback) {
EXPECT_TRUE(handle.socket());
IPEndPoint endpoint;
handle.socket()->GetLocalAddress(&endpoint);
- EXPECT_EQ(kIPv4AddressSize, endpoint.address().size());
+ EXPECT_EQ(kIPv4AddressSize, endpoint.address().bytes().size());
EXPECT_EQ(0u, handle.connection_attempts().size());
EXPECT_EQ(1, client_socket_factory_.allocation_count());
}
@@ -1088,7 +1088,7 @@ TEST_F(TransportClientSocketPoolTest,
// Verify that the socket used is connected to the fallback IPv4 address.
IPEndPoint endpoint;
handle.socket()->GetLocalAddress(&endpoint);
- EXPECT_EQ(kIPv4AddressSize, endpoint.address().size());
+ EXPECT_EQ(kIPv4AddressSize, endpoint.address().bytes().size());
EXPECT_EQ(2, client_socket_factory_.allocation_count());
// Verify that TCP FastOpen was not turned on for the socket.
EXPECT_FALSE(handle.socket()->UsingTCPFastOpen());
@@ -1127,7 +1127,7 @@ TEST_F(TransportClientSocketPoolTest,
// Verify that the socket used is connected to the IPv6 address.
IPEndPoint endpoint;
handle.socket()->GetLocalAddress(&endpoint);
- EXPECT_EQ(kIPv6AddressSize, endpoint.address().size());
+ EXPECT_EQ(kIPv6AddressSize, endpoint.address().bytes().size());
EXPECT_EQ(1, client_socket_factory_.allocation_count());
// Verify that TCP FastOpen was not turned on for the socket.
EXPECT_FALSE(handle.socket()->UsingTCPFastOpen());

Powered by Google App Engine
This is Rietveld 408576698