content/renderer/p2p/ipc_socket_factory.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/ipc_socket_factory.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback eroman Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc ('k') | device/bluetooth/bluetooth_socket_win.cc » ('j') | net/base/ip_endpoint.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/p2p/ipc_socket_factory.cc

diff --git a/content/renderer/p2p/ipc_socket_factory.cc b/content/renderer/p2p/ipc_socket_factory.cc

index 779bb216dd5f3b9037e59321ed4842376c7eaf90..5f47187ca0430590709410fd5062f34b97edd6af 100644

--- a/content/renderer/p2p/ipc_socket_factory.cc

+++ b/content/renderer/p2p/ipc_socket_factory.cc

@@ -564,8 +564,8 @@ void IpcPacketSocket::OnOpen(const net::IPEndPoint& local_address,

// |remote_address| could be unresolved if the connection is behind a

// proxy.

if (!remote_address.address().empty() &&

- jingle_glue::IPEndPointToSocketAddress(

- remote_address, &jingle_socket_address)) {

+ jingle_glue::IPEndPointToSocketAddress(remote_address,

eroman 2016/01/13 23:19:42 Consider remove this edit, since it is just a form

martijnc 2016/01/14 22:48:16 Done.

+ &jingle_socket_address)) {

// Set only the IP address.

remote_address_.SetResolvedIP(jingle_socket_address.ipaddr());

}