content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback eroman Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc ('k') | content/renderer/p2p/ipc_socket_factory.cc » ('j') | content/renderer/p2p/ipc_socket_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

index d99b25ba627be600c3590a99d54af0513a4da9c3..860fe6685199cbdfafa4e3728ccfe467da16cc69 100644

--- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

@@ -493,7 +493,8 @@ void PepperUDPSocketMessageFilter::DoBind(

PP_NetAddress_Private net_address = NetAddressPrivateImpl::kInvalidNetAddress;

if (!NetAddressPrivateImpl::IPEndPointToNetAddress(

- bound_address.address(), bound_address.port(), &net_address)) {

+ bound_address.address().bytes(), bound_address.port(),

+ &net_address)) {

SendBindError(context, PP_ERROR_ADDRESS_INVALID);

return;

}

@@ -645,7 +646,8 @@ void PepperUDPSocketMessageFilter::OnRecvFromCompleted(int net_result) {

PP_NetAddress_Private addr = NetAddressPrivateImpl::kInvalidNetAddress;

if (pp_result >= 0 &&

!NetAddressPrivateImpl::IPEndPointToNetAddress(

- recvfrom_address_.address(), recvfrom_address_.port(), &addr)) {

+ recvfrom_address_.address().bytes(), recvfrom_address_.port(),

+ &addr)) {

pp_result = PP_ERROR_ADDRESS_INVALID;

}