content/browser/renderer_host/pepper/pepper_socket_utils.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_socket_utils.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback eroman Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc ('k') | content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc » ('j') | content/renderer/p2p/ipc_socket_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_socket_utils.cc

diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.cc b/content/browser/renderer_host/pepper/pepper_socket_utils.cc

index c421fe29f70c602407cd1711afded5bceb280d1f..161c5b1e1925f533d5ebc2dd2cd3e3a5ae8d500f 100644

--- a/content/browser/renderer_host/pepper/pepper_socket_utils.cc

+++ b/content/browser/renderer_host/pepper/pepper_socket_utils.cc

@@ -181,11 +181,12 @@ std::string addressToFirewallString(const net::IPAddressNumber& address) {

void OpenFirewallHole(const net::IPEndPoint& address,

chromeos::FirewallHole::PortType type,

FirewallHoleOpenCallback callback) {

- if (isLoopbackAddress(address.address())) {

+ if (isLoopbackAddress(address.address().bytes())) {

callback.Run(nullptr);

return;

}

- std::string address_string = addressToFirewallString(address.address());

+ std::string address_string =

+ addressToFirewallString(address.address().bytes());

chromeos::FirewallHole::Open(type, address.port(), address_string, callback);

}