Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 15653007: Introduce panScrollTest() for simplify pan-scroll test scripts (Closed)

Created:
7 years, 6 months ago by yosin_UTC9
Modified:
7 years, 6 months ago
Reviewers:
jamesr, tdanderson
CC:
blink-reviews, eae+blinkwatch, tdanderson
Visibility:
Public.

Description

This patch introduces panScrollTest() to provide following test steps to scripts: - start pan-scroll - stop pan-scroll BUG=n/a R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151627

Patch Set 1 : 2013-05-31T12:59 #

Total comments: 1

Patch Set 2 : 2013-06-03T12:33 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -377 lines) Patch
M LayoutTests/fast/events/panScroll-click.html View 2 chunks +12 lines, -102 lines 0 comments Download
M LayoutTests/fast/events/panScroll-click-expected.txt View 1 chunk +4 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/panScroll-drag.html View 2 chunks +12 lines, -100 lines 0 comments Download
M LayoutTests/fast/events/panScroll-drag-expected.txt View 1 chunk +4 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/panScroll-event-fired.html View 1 chunk +36 lines, -44 lines 0 comments Download
M LayoutTests/fast/events/panScroll-event-fired-expected.txt View 1 chunk +5 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/panScroll-in-iframe.html View 1 chunk +19 lines, -62 lines 0 comments Download
M LayoutTests/fast/events/panScroll-in-iframe-expected.txt View 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/fast/events/panScroll-nested-divs.html View 1 chunk +44 lines, -46 lines 0 comments Download
M LayoutTests/fast/events/panScroll-nested-divs-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
A LayoutTests/fast/events/resources/panScroll.js View 1 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. P.S. Test failures aren't related to this ...
7 years, 6 months ago (2013-05-30 14:35:24 UTC) #1
jamesr
lgtm https://codereview.chromium.org/15653007/diff/15001/LayoutTests/fast/events/resources/panScroll.js File LayoutTests/fast/events/resources/panScroll.js (right): https://codereview.chromium.org/15653007/diff/15001/LayoutTests/fast/events/resources/panScroll.js#newcode3 LayoutTests/fast/events/resources/panScroll.js:3: var PAN_SCROLL_RADIUS = 15; // from WebCore/platform/ScrollView.h js ...
7 years, 6 months ago (2013-05-31 18:32:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/15653007/15001
7 years, 6 months ago (2013-05-31 18:35:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8168
7 years, 6 months ago (2013-05-31 21:15:40 UTC) #4
yosin_UTC9
7 years, 6 months ago (2013-06-03 03:37:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r151627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698