third_party/WebKit/Source/core/css/CSSSelectorList.h - Issue 1565263003: Implement CSS parser part for ::slotted pseudo element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSelectorList.h

Issue 1565263003: Implement CSS parser part for ::slotted pseudo element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address rune's first round of comments in layout test. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSSelector.cpp ('K') | « third_party/WebKit/Source/core/css/CSSSelector.cpp ('k') | third_party/WebKit/Source/core/css/CSSSelectorList.cpp » ('j') | third_party/WebKit/Source/core/css/CSSSelectorList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSSelectorList.h

diff --git a/third_party/WebKit/Source/core/css/CSSSelectorList.h b/third_party/WebKit/Source/core/css/CSSSelectorList.h

index 94b371d4f42bc0a09d19f09cfbb8430e0c59ea87..b50a1364da34d826d38af9d525b823acaa71a805 100644

--- a/third_party/WebKit/Source/core/css/CSSSelectorList.h

+++ b/third_party/WebKit/Source/core/css/CSSSelectorList.h

@@ -79,9 +79,8 @@ public:

bool selectorNeedsUpdatedDistribution(size_t index) const;

- // TODO(kochi): "ShadowDistributed" means the selector has ::content pseudo element.

- // Once ::slotted is introduced, come up with more readable name.

bool selectorHasShadowDistributed(size_t index) const;

rune 2016/01/13 09:59:09 I would have renamed this to selectorHasContentPse

kochi 2016/01/14 09:02:20 Done. I'd like to rename other instances of "shad

+ bool selectorHasShadowSlotted(size_t index) const;

rune 2016/01/13 09:59:09 ... and selectorHasSlottedPseudo perhaps?

kochi 2016/01/14 09:02:20 Done.

bool selectorUsesDeepCombinatorOrShadowPseudo(size_t index) const;

String selectorsText() const;