third_party/WebKit/Source/core/css/CSSSelectorList.cpp - Issue 1565263003: Implement CSS parser part for ::slotted pseudo element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSSelectorList.cpp

Issue 1565263003: Implement CSS parser part for ::slotted pseudo element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address rune's first round of comments in layout test. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSSelectorList.h ('K') | « third_party/WebKit/Source/core/css/CSSSelectorList.h ('k') | third_party/WebKit/Source/core/css/RuleFeature.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSSelectorList.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSSelectorList.cpp b/third_party/WebKit/Source/core/css/CSSSelectorList.cpp

index 114fb8460e58dd0739288b723d1235976e1d1985..8fa536fe921cd859080de8ececb3faa696151fbb 100644

--- a/third_party/WebKit/Source/core/css/CSSSelectorList.cpp

+++ b/third_party/WebKit/Source/core/css/CSSSelectorList.cpp

@@ -168,6 +168,13 @@ bool CSSSelectorList::selectorHasShadowDistributed(size_t index) const

}, selectorAt(index));

}

+bool CSSSelectorList::selectorHasShadowSlotted(size_t index) const

+ return forEachTagSelector([](const CSSSelector& selector) -> bool {

+ return selector.relationIsAffectedByPseudoSlotted();

rune 2016/01/13 09:59:09 If you remove the relationIsAffectedByPseudoSlotte

kochi 2016/01/14 09:02:20 Done.

+ }, selectorAt(index));

bool CSSSelectorList::selectorUsesDeepCombinatorOrShadowPseudo(size_t index) const

{

return forEachTagSelector([](const CSSSelector& selector) -> bool {