Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1565173002: Download a prebuilt apprtc from google storage instead of building it. (Closed)

Created:
4 years, 11 months ago by phoglund_chromium
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Download a prebuilt apprtc from google storage instead of building it. This should work around node.js issues. To update prebuilt_apprtc.zip: 1. Clone https://github.com/webrtc/apprtc 2. Follow instructions up to grunt build 3. zip -r prebuilt_apprtc.zip apprtc/ 4. cp prebuilt_apprtc.zip /.../webrtc.DEPS/prebuilt_apprtc.zip 4. upload_to_google_storage.py prebuilt_apprtc.zip \ --bucket=chromium-webrtc-resources from the webrtc.DEPS dir. BUG=569494 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/0c3e9864d9a2a5b86e94374bc5d995c59e09c7e7

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -164 lines) Patch
M DEPS View 1 4 chunks +1 line, -15 lines 0 comments Download
D build_apprtc_appengine_app.py View 1 chunk +0 lines, -78 lines 0 comments Download
M download_appengine_and_mercurial.py View 1 1 chunk +0 lines, -59 lines 0 comments Download
A + download_apprtc_appengine_and_mercurial.py View 1 2 chunks +7 lines, -0 lines 0 comments Download
D node/linux/node.tar.gz.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D node/mac/node.tar.gz.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D node/win/README View 1 chunk +0 lines, -9 lines 0 comments Download
D node/win/node.zip.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A prebuilt_apprtc.zip.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
phoglund_chromium
4 years, 11 months ago (2016-01-08 10:31:47 UTC) #2
kjellander_chromium
Nice job! lgtm
4 years, 11 months ago (2016-01-08 13:01:29 UTC) #3
phoglund_chromium
4 years, 11 months ago (2016-01-08 13:26:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0c3e9864d9a2a5b86e94374bc5d995c59e09c7e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698