Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 1565113004: Change to wire up opnames in SkGpuDevice (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@audittrail-initial
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : add a bunch of macros to interact with GrAuditTrail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -21 lines) Patch
M include/gpu/GrConfig.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/private/GrAuditTrail.h View 1 2 3 chunks +15 lines, -1 line 0 comments Download
M src/gpu/GrAuditTrail.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTracing.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 15 chunks +20 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
joshualitt
This is a fairly simple change, but I'm adding everyone who might have an opinion.
4 years, 11 months ago (2016-01-08 15:32:48 UTC) #3
robertphillips
lgtm
4 years, 11 months ago (2016-01-08 16:07:12 UTC) #4
bsalomon
On 2016/01/08 16:07:12, robertphillips wrote: > lgtm lgtm
4 years, 11 months ago (2016-01-08 16:48:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565113004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565113004/40001
4 years, 11 months ago (2016-01-11 18:21:39 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 18:39:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5651ee6376dc3271ea8f4fc91b037c8f361c3cfa

Powered by Google App Engine
This is Rietveld 408576698