Add concept of bot config and test spec database (BotConfigAndTestDB).

scripts/slave/recipe_modules/auto_bisect/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """API for the bisect recipe module.
 
 This API is meant to enable the bisect recipe to bisect any chromium-supported
 platform for any test that can be run via buildbot, perf or otherwise.
 """
 
@@ skipping 113 matching lines @@
         self.m.path['checkout'].join('tools', 'run-bisect-perf-regression.py'),
         ['-w', self.m.path['slave_build']] + args,
         name='Running Bisection',
         xvfb=True, **kwargs)
 
   def run_local_test_run(self, api, test_config_params):  # pragma: no cover
     mastername = api.properties.get('mastername')
     buildername = api.properties.get('buildername')
     api.chromium_tests.configure_build(mastername, buildername)
     api.gclient.apply_config('perf')
-    update_step, master_dict, _ = \
+    update_step, bot_db = \
         api.chromium_tests.prepare_checkout(
             mastername, buildername,
             root_solution_revision=test_config_params['revision'])
-    self.start_test_run_for_bisect(api, update_step, master_dict,
+    self.start_test_run_for_bisect(api, update_step, bot_db,
                                    test_config_params, run_locally=True)
 
-  def start_test_run_for_bisect(self, api, update_step, master_dict,
+  def start_test_run_for_bisect(self, api, update_step, bot_db,
                                 test_config_params, run_locally=False):
     mastername = api.properties.get('mastername')
     buildername = api.properties.get('buildername')
-    bot_config = master_dict.get('builders', {}).get(buildername)
+    bot_config = bot_db.get_bot_config(mastername, buildername)
     if not run_locally:
       api.bisect_tester.upload_job_url()
     if api.chromium.c.TARGET_PLATFORM == 'android':
       # The best way to ensure the old build directory is not used is to
       # remove it.
       build_dir = self.m.chromium.c.build_dir.join(
           self.m.chromium.c.build_config_fs)
       self.m.file.rmtree('build directory', build_dir)
 
       # crbug.com/535218, the way android builders on tryserver.chromium.perf
@@ skipping 16 matching lines @@
             'moving full-build-linux to out/Release ',
             """
             import shutil
             import sys
             shutil.move(sys.argv[1], sys.argv[2])
             """,
             args=[zip_dir, build_dir],
         )
     else:
       api.chromium_tests.download_and_unzip_build(
-          mastername, buildername, update_step, master_dict,
+          mastername, buildername, update_step, bot_db,
           build_archive_url=test_config_params['parent_build_archive_url'],
           build_revision=test_config_params['parent_got_revision'],
           override_bot_type='tester')
 
       api.chromium_tests.tests_for_builder(
-          mastername, buildername, update_step, master_dict,
+          mastername, buildername, update_step, bot_db,
           override_bot_type='tester')
 
     tests = [api.chromium_tests.steps.BisectTest(test_config_params)]
 
     if not tests:  # pragma: no cover
       return
     api.chromium_tests.configure_swarming(  # pragma: no cover
         'chromium', precommit=False, mastername=mastername)
     test_runner = api.chromium_tests.create_test_runner(api, tests)
 
     with api.chromium_tests.wrap_chromium_tests(mastername, tests):
       if api.chromium.c.TARGET_PLATFORM == 'android':
         api.chromium_android.adb_install_apk('ChromePublic.apk')
       test_runner()
 
-  def start_try_job(self, api, update_step=None, master_dict=None, **kwargs):
-    if master_dict is None:  # pragma: no cover
-      master_dict = {}
+  def start_try_job(self, api, update_step=None, bot_db=None, **kwargs):
+    if bot_db is None:  # pragma: no cover
+      bot_db = api.chromium_tests.create_bot_db_from_master_dict(
+          '', None, None)
     affected_files = self.m.tryserver.get_files_affected_by_patch()
 
     # Avoid duplication of device setup steps for bisect recipe tester which
     # is ran while executing tests in chromium_tests.wrap_chromium_tests and
     # also we don't want to execute runhooks since this just tests the build.
     if (api.properties.get('bisect_config') is None and
         api.chromium.c.TARGET_PLATFORM == 'android'):
       api.chromium_android.common_tests_setup_steps(perf_setup=True)
       api.chromium.runhooks()
     try:
       # Run legacy bisect script if the patch contains bisect.cfg.
       if BISECT_CONFIG_FILE in affected_files:
         kwargs['extra_src'] = ''
         kwargs['path_to_config'] = ''
         self.run_bisect_script(**kwargs)
       elif api.properties.get('bisect_config'):
         # We can distinguish between a config for a full bisect vs a single
         # test by checking for the presence of the good_revision key.
         # Also, at the moment android is not supported and return_code mode
         # does not require device affinity.
         platform = self.m.chromium.c.TARGET_PLATFORM
         test_type = api.properties.get('bisect_config').get('test_type')
         if (api.properties.get('bisect_config').get('good_revision')
             and platform != 'android' and test_type != 'return_code'):
           local_bisect.perform_bisect(self)  # pragma: no cover
         else:
-          self.start_test_run_for_bisect(api, update_step, master_dict,
+          self.start_test_run_for_bisect(api, update_step, bot_db,
                                          api.properties)
       else:
         self.m.perf_try.start_perf_try_job(
-            affected_files, update_step, master_dict)
+            affected_files, update_step, bot_db)
     finally:
       # Avoid duplication of device setup steps for bisect recipe tester, which
       # are run while running tests in chromium_tests.wrap_chromium_tests.
       if (api.properties.get('bisect_config') is None and
           api.chromium.c.TARGET_PLATFORM == 'android'):
         api.chromium_android.common_tests_final_steps()