Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: media/formats/mpeg/mpeg_audio_stream_parser_base.h

Issue 1564983003: MSE: Log a warning if muxed AV media segment has no A or has no V block (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mpeg/mpeg_audio_stream_parser_base.h
diff --git a/media/formats/mpeg/mpeg_audio_stream_parser_base.h b/media/formats/mpeg/mpeg_audio_stream_parser_base.h
index 0b72be90cefead5bd122fff769e4fb4b4a8335e5..6514e3610d203c985dd3d99d67643f3c9505c3b0 100644
--- a/media/formats/mpeg/mpeg_audio_stream_parser_base.h
+++ b/media/formats/mpeg/mpeg_audio_stream_parser_base.h
@@ -39,7 +39,7 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {
bool ignore_text_tracks,
const EncryptedMediaInitDataCB& encrypted_media_init_data_cb,
const NewMediaSegmentCB& new_segment_cb,
- const base::Closure& end_of_segment_cb,
+ const EndMediaSegmentCB& end_of_segment_cb,
const scoped_refptr<MediaLog>& media_log) override;
void Flush() override;
bool Parse(const uint8_t* buf, int size) override;
@@ -129,7 +129,8 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {
// If |end_of_segment| is set to true, then |end_of_segment_cb_| is called
// after |new_buffers_cb_| to signal that these buffers represent the end of a
// media segment.
- // Returns true if the buffers are sent successfully.
+ // Returns true if the buffers (and the optional end of segment signal) are
+ // sent successfully.
bool SendBuffers(BufferQueue* buffers, bool end_of_segment);
State state_;
@@ -138,7 +139,7 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {
NewConfigCB config_cb_;
NewBuffersCB new_buffers_cb_;
NewMediaSegmentCB new_segment_cb_;
- base::Closure end_of_segment_cb_;
+ EndMediaSegmentCB end_of_segment_cb_;
scoped_refptr<MediaLog> media_log_;
ByteQueue queue_;

Powered by Google App Engine
This is Rietveld 408576698