Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: media/formats/mp4/mp4_stream_parser_unittest.cc

Issue 1564983003: MSE: Log a warning if muxed AV media segment has no A or has no V block (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/mp4_stream_parser_unittest.cc
diff --git a/media/formats/mp4/mp4_stream_parser_unittest.cc b/media/formats/mp4/mp4_stream_parser_unittest.cc
index 79f68c1fe2d3988fe1c1997832c9cd28c65aab18..b09b7eae1b7f797335ac395431e58b44a64864ab 100644
--- a/media/formats/mp4/mp4_stream_parser_unittest.cc
+++ b/media/formats/mp4/mp4_stream_parser_unittest.cc
@@ -156,10 +156,11 @@ class MP4StreamParserTest : public testing::Test {
lower_bound_ = kNoDecodeTimestamp();
}
- void EndOfSegmentF() {
+ bool EndOfSegmentF() {
DVLOG(1) << "EndOfSegmentF()";
lower_bound_ =
DecodeTimestamp::FromPresentationTime(base::TimeDelta::Max());
+ return true; // BIG TODO test !
chcunningham 2016/01/07 22:23:57 :)
wolenetz 2016/01/16 01:23:35 No longer changed (PS5, at least).
}
void InitializeParserAndExpectLiveness(

Powered by Google App Engine
This is Rietveld 408576698