Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: media/formats/mp4/mp4_stream_parser.cc

Issue 1564983003: MSE: Log a warning if muxed AV media segment has no A or has no V block (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/mp4_stream_parser.cc
diff --git a/media/formats/mp4/mp4_stream_parser.cc b/media/formats/mp4/mp4_stream_parser.cc
index ee88ea14ef1142e21a3594f33ccc36275db78b85..94fb0680e1cd3aa5bf8b05aa873dc1de8e3a11fb 100644
--- a/media/formats/mp4/mp4_stream_parser.cc
+++ b/media/formats/mp4/mp4_stream_parser.cc
@@ -54,7 +54,7 @@ void MP4StreamParser::Init(
bool /* ignore_text_tracks */,
const EncryptedMediaInitDataCB& encrypted_media_init_data_cb,
const NewMediaSegmentCB& new_segment_cb,
- const base::Closure& end_of_segment_cb,
+ const EndMediaSegmentCB& end_of_segment_cb,
const scoped_refptr<MediaLog>& media_log) {
DCHECK_EQ(state_, kWaitingForInit);
DCHECK(init_cb_.is_null());
@@ -426,7 +426,10 @@ bool MP4StreamParser::EnqueueSample(BufferQueue* audio_buffers,
return false;
ChangeState(kParsingBoxes);
- end_of_segment_cb_.Run();
+ *err = !end_of_segment_cb_.Run();
+ if (*err)
+ return false;
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698