Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1564953003: bluetooth: Remove BluetoothDevice.paired (Closed)

Created:
4 years, 11 months ago by François Beaufort
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Remove BluetoothDevice.paired It looks like CoreBluetooth has no way to get this information, so we can't expose it universally. It's a holdover from chrome.bluetooth. BUG=421668 Committed: https://crrev.com/612a2f8cdee39bd57a9cc214c744ece855e2813d Cr-Commit-Position: refs/heads/master@{#368605}

Patch Set 1 #

Messages

Total messages: 20 (9 generated)
fbeaufortchromium
Hey Jeffrey, can you have a look at this CL? I think I'm missing some ...
4 years, 11 months ago (2016-01-07 12:38:01 UTC) #3
Jeffrey Yasskin
LGTM. +Giovanni as an FYI.
4 years, 11 months ago (2016-01-09 00:43:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564953003/1
4 years, 11 months ago (2016-01-11 10:45:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/134056)
4 years, 11 months ago (2016-01-11 10:52:47 UTC) #9
fbeaufortchromium
tsepez@chromium.org: Please review changes in content/common/bluetooth/bluetooth_messages.h
4 years, 11 months ago (2016-01-11 10:54:08 UTC) #11
Tom Sepez
RS LGTM on deleting a member.
4 years, 11 months ago (2016-01-11 16:51:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564953003/1
4 years, 11 months ago (2016-01-11 16:54:23 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 16:59:35 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/612a2f8cdee39bd57a9cc214c744ece855e2813d Cr-Commit-Position: refs/heads/master@{#368605}
4 years, 11 months ago (2016-01-11 17:00:33 UTC) #18
ortuno
In the future it would be nice if changes like this had a corresponding change ...
4 years, 11 months ago (2016-01-11 20:36:13 UTC) #19
fbeaufortchromium
4 years, 11 months ago (2016-01-12 12:16:36 UTC) #20
Message was sent while issue was closed.
On 2016/01/11 20:36:13, ortuno (OOO until Jan 10th) wrote:
> In the future it would be nice if changes like this had a corresponding change
> in the spec. If we change our implementation without changing the spec people
> are going to run into different behavior in each browser.

There is already one: https://github.com/WebBluetoothCG/web-bluetooth/issues/189

Powered by Google App Engine
This is Rietveld 408576698