Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1564863002: Get rid of AXScrollView and AXScrollbar (Closed)

Created:
4 years, 11 months ago by dmazzoni
Modified:
4 years, 11 months ago
Reviewers:
je_julie, dglazkov
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, eae+blinkwatch, jam, je_julie, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nektarios, nektar+watch_chromium.org, plundblad+watch_chromium.org, rwlbuis, sof, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dump_oopif_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of AXScrollView and AXScrollbar They're an unnecessary abstraction, leftover from WebKit and just getting in the way. Now an iframe's accessibility object has the child frame document's accessibility object as its immediate child. This depends on previous changes that put all of the document scroll attributes and methods on the document's AXObject rather than on its parent AXScrollView. This also eliminates an arbitrary and confusing difference between local and remote frames in the accessibility tree. BUG=484878 Committed: https://crrev.com/d79d97eba65b5fd1303b1ce18d6ac4bab9dce970 Cr-Commit-Position: refs/heads/master@{#370342}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Fix Android expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -852 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M content/test/data/accessibility/html/frameset-expected-mac.txt View 1 chunk +11 lines, -13 lines 0 comments Download
M content/test/data/accessibility/html/iframe-coordinates-expected-android.txt View 1 1 chunk +6 lines, -8 lines 0 comments Download
M content/test/data/accessibility/html/iframe-coordinates-expected-blink.txt View 1 chunk +6 lines, -8 lines 0 comments Download
M content/test/data/accessibility/html/iframe-coordinates-expected-mac.txt View 1 chunk +6 lines, -8 lines 0 comments Download
M content/test/data/accessibility/html/iframe-coordinates-expected-win.txt View 1 chunk +7 lines, -8 lines 0 comments Download
M content/test/data/accessibility/html/iframe-expected-android.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/iframe-expected-blink.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/iframe-expected-mac.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/iframe-expected-win.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/iframe-presentational-expected-android.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/iframe-presentational-expected-mac.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/iframe-presentational-expected-win.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-in-iframe-closed-expected-android.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-in-iframe-closed-expected-mac.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-in-iframe-closed-expected-win.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-in-iframe-opened-expected-android.txt View 1 chunk +4 lines, -5 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-in-iframe-opened-expected-mac.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-in-iframe-opened-expected-win.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/deleting-iframe-destroys-axcache-expected.txt View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/loading-iframe-sends-notification.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/loading-iframe-updates-axtree.html View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/AXObjectCache.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 6 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 8 chunks +36 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 3 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 5 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 9 chunks +2 lines, -92 lines 0 comments Download
D third_party/WebKit/Source/modules/accessibility/AXScrollView.h View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/Source/modules/accessibility/AXScrollView.cpp View 1 chunk +0 lines, -260 lines 0 comments Download
D third_party/WebKit/Source/modules/accessibility/AXScrollbar.h View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/modules/accessibility/AXScrollbar.cpp View 1 chunk +0 lines, -124 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dmazzoni
4 years, 11 months ago (2016-01-06 18:48:11 UTC) #2
dglazkov
lgtm
4 years, 11 months ago (2016-01-06 18:55:19 UTC) #3
je_julie
I'm happy that we have healthier code than before. LGTM! https://codereview.chromium.org/1564863002/diff/1/third_party/WebKit/Source/core/dom/AXObjectCache.h File third_party/WebKit/Source/core/dom/AXObjectCache.h (right): https://codereview.chromium.org/1564863002/diff/1/third_party/WebKit/Source/core/dom/AXObjectCache.h#newcode130 ...
4 years, 11 months ago (2016-01-07 06:56:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564863002/40001
4 years, 11 months ago (2016-01-20 05:39:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-20 08:48:20 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 08:49:14 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d79d97eba65b5fd1303b1ce18d6ac4bab9dce970
Cr-Commit-Position: refs/heads/master@{#370342}

Powered by Google App Engine
This is Rietveld 408576698