Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1564863002: Get rid of AXScrollView and AXScrollbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump_oopif_3
Patch Set: Fix Android expectation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index f92b88a3ca8dfae40d31b5dd465cec633685a0f8..5d68ff08ec5d03d29a1993c9a870a18a7d54d514 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -245,10 +245,8 @@ void FrameView::forAllNonThrottledFrameViews(Function function)
void FrameView::removeFromAXObjectCache()
{
- if (AXObjectCache* cache = axObjectCache()) {
- cache->remove(this);
+ if (AXObjectCache* cache = axObjectCache())
cache->childrenChanged(m_frame->pagePopupOwner());
- }
}
void FrameView::init()
@@ -2999,8 +2997,6 @@ void FrameView::setLayoutSizeInternal(const IntSize& size)
void FrameView::didAddScrollbar(Scrollbar& scrollbar, ScrollbarOrientation orientation)
{
ScrollableArea::didAddScrollbar(scrollbar, orientation);
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
void FrameView::setTopControlsViewportAdjustment(float adjustment)
@@ -3038,8 +3034,6 @@ void FrameView::setHasHorizontalScrollbar(bool hasBar)
m_horizontalScrollbar->styleChanged();
} else {
willRemoveScrollbar(*m_horizontalScrollbar, HorizontalScrollbar);
- if (AXObjectCache* cache = axObjectCache())
- cache->remove(m_horizontalScrollbar.get());
// If the scrollbar has been marked as overlapping the window resizer,
// then its removal should reduce the count.
if (m_horizontalScrollbar->overlapsResizer())
@@ -3047,8 +3041,6 @@ void FrameView::setHasHorizontalScrollbar(bool hasBar)
removeChild(m_horizontalScrollbar.get());
m_horizontalScrollbar->disconnectFromScrollableArea();
m_horizontalScrollbar = nullptr;
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
setScrollCornerNeedsPaintInvalidation();
@@ -3066,8 +3058,6 @@ void FrameView::setHasVerticalScrollbar(bool hasBar)
m_verticalScrollbar->styleChanged();
} else {
willRemoveScrollbar(*m_verticalScrollbar, VerticalScrollbar);
- if (AXObjectCache* cache = axObjectCache())
- cache->remove(m_verticalScrollbar.get());
// If the scrollbar has been marked as overlapping the window resizer,
// then its removal should reduce the count.
if (m_verticalScrollbar->overlapsResizer())
@@ -3075,8 +3065,6 @@ void FrameView::setHasVerticalScrollbar(bool hasBar)
removeChild(m_verticalScrollbar.get());
m_verticalScrollbar->disconnectFromScrollableArea();
m_verticalScrollbar = nullptr;
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
setScrollCornerNeedsPaintInvalidation();
« no previous file with comments | « third_party/WebKit/Source/core/dom/AXObjectCache.h ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698