Use ANDROID_JAVA_UI build flag for UI elements in Chrome dir

Use ANDROID_JAVA_UI build flag for UI elements in Chrome dir


We introduced a new build flag ANDROID_JAVA_UI as a result of Aura Android effort.
So this CL changes some of the UI related code in chrome directory to use this flag.


BUG=None

[bshe, 2016-01-07 16:58:58]

Patchset #2 (id:20001) has been deleted

[bshe, 2016-01-07 21:53:43]

Patchset #3 (id:60001) has been deleted

[bshe, 2016-01-07 21:59:00]

bshe@chromium.org changed reviewers:
+ mfomitchev@chromium.org, sievers@chromium.org

[bshe, 2016-01-07 21:59:00]

Hi Mikhail and Daniel.

Do you guys mind to take a look at this CL? I reverted a few of my previous CLs
for Aura Android. But since we are keeping ANDROID_JAVA_UI. This CL basically
use ANDROID_JAVA_UI to replace OS_ANDROID in a few places where we used to use
(OS_ANDROID || USE_AURA).

Thanks!

[mfomitchev, 2016-01-08 16:19:02]

autofill_popup_controller_impl.h/cc LGTM. I am not too confident about all the
spots in chrome_browser_main.h/cc. I will let Dan review that one.

[no sievers, 2016-01-08 17:57:41]

On 2016/01/08 16:19:02, mfomitchev wrote:
> autofill_popup_controller_impl.h/cc LGTM. I am not too confident about all the
> spots in chrome_browser_main.h/cc. I will let Dan review that one.

agreed. maybe we should just leave it in the state where JAVA_UI reflects more
direct dependencies on higher-level Java code, rather than extending it further.
(it should be somewhat consistent now, but unfortunately it will be hard to
enforce people preferring this flag over the vague OS_ANDROID when making
changes in the future.)

[bshe, 2016-01-08 18:44:34]

On 2016/01/08 17:57:41, sievers wrote:
> On 2016/01/08 16:19:02, mfomitchev wrote:
> > autofill_popup_controller_impl.h/cc LGTM. I am not too confident about all
the
> > spots in chrome_browser_main.h/cc. I will let Dan review that one.
> 
> agreed. maybe we should just leave it in the state where JAVA_UI reflects more
> direct dependencies on higher-level Java code, rather than extending it
further.
> (it should be somewhat consistent now, but unfortunately it will be hard to
> enforce people preferring this flag over the vague OS_ANDROID when making
> changes in the future.)

Sounds good.  I will remove the changes in chrome_browser_main.*

[bshe, 2016-01-08 19:53:58]

bshe@chromium.org changed reviewers:
+ estade@chromium.org

[bshe, 2016-01-08 19:53:58]

+estade@ for owner
Thanks

[Evan Stade, 2016-01-09 00:03:02]

lgtm

https://codereview.chromium.org/1564783006/diff/90001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_controller_impl.h (right):

https://codereview.chromium.org/1564783006/diff/90001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_controller_impl.h:139: #if
!BUILDFLAG(ANDROID_JAVA_UI)
imo this is sort of hard to read. On the one hand, it makes sense that Windows
doesn't define ANDROID_JAVA_UI but on the other hand, this looks like something
that should only be relevant to android. This is more readable if you ask me:

if !(defined(OS_ANDROID) && BUILDFLAG(ANDROID_JAVA_UI))

This is longer so it's understandable if you don't like it. Just my two cents.

[bshe, 2016-01-11 15:52:03]

Thanks for review!

https://codereview.chromium.org/1564783006/diff/90001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_controller_impl.h (right):

https://codereview.chromium.org/1564783006/diff/90001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_controller_impl.h:139: #if
!BUILDFLAG(ANDROID_JAVA_UI)
On 2016/01/09 00:03:02, Evan Stade wrote:
> imo this is sort of hard to read. On the one hand, it makes sense that Windows
> doesn't define ANDROID_JAVA_UI but on the other hand, this looks like
something
> that should only be relevant to android. This is more readable if you ask me:
> 
> if !(defined(OS_ANDROID) && BUILDFLAG(ANDROID_JAVA_UI))
> 
> This is longer so it's understandable if you don't like it. Just my two cents.

I see your point. It is indeed more clear but longer. There were other places
that use the same
short version. So I would lean toward to keep it as it is if you dont mind.
Since the flag has
ANDROD in it, so it shouldn't be too hard to associated the flag with ANDROID
platform only.

[bshe, 2016-02-18 18:37:36]

The CQ bit was checked by bshe@chromium.org

[bshe, 2016-02-18 18:37:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mfomitchev@chromium.org
Link to the patchset: https://codereview.chromium.org/1564783006/#ps90001
(title: " ")

[commit-bot: I haz the power, 2016-02-18 18:39:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564783006/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564783006/90001

[commit-bot: I haz the power, 2016-02-18 18:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 18:50:55]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[bshe, 2016-02-23 19:24:38]

On 2016/02/18 18:50:55, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
>   android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
>   android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
>   android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
>   cast_shell_android on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
>   cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
>   chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
>   chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
>   chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
>   linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
>   ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
>   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
>   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
>   win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
>   win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Looks like this code has been refactored and the changes are no longer valid. So
close it without upstream.

[bshe, 2016-02-23 19:24:53]

Description was changed from

==========
Use ANDROID_JAVA_UI build flag for UI elements in Chrome dir


We introduced a new build flag ANDROID_JAVA_UI as a result of Aura Android
effort.
So this CL changes some of the UI related code in chrome directory to use this
flag.


BUG=None
==========

to

==========
Use ANDROID_JAVA_UI build flag for UI elements in Chrome dir


We introduced a new build flag ANDROID_JAVA_UI as a result of Aura Android
effort.
So this CL changes some of the UI related code in chrome directory to use this
flag.


BUG=None
==========