Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

Issue 1564773003: Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/include/formfiller/FFL_ComboBox.h" 7 #include "fpdfsdk/include/formfiller/FFL_ComboBox.h"
8 8
9 #include "fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h" 9 #include "fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h"
10 #include "fpdfsdk/include/formfiller/FFL_FormFiller.h" 10 #include "fpdfsdk/include/formfiller/FFL_FormFiller.h"
11 #include "fpdfsdk/include/formfiller/FFL_IFormFiller.h" 11 #include "fpdfsdk/include/formfiller/FFL_IFormFiller.h"
12 #include "fpdfsdk/include/fsdk_common.h" 12 #include "fpdfsdk/include/fsdk_common.h"
13 #include "fpdfsdk/include/fsdk_mgr.h" 13 #include "fpdfsdk/include/fsdk_mgr.h"
14 #include "fpdfsdk/include/pdfwindow/PWL_ComboBox.h" 14 #include "fpdfsdk/include/pdfwindow/PWL_ComboBox.h"
15 15
16 CFFL_ComboBox::CFFL_ComboBox(CPDFDoc_Environment* pApp, CPDFSDK_Annot* pAnnot) 16 CFFL_ComboBox::CFFL_ComboBox(CPDFDoc_Environment* pApp, CPDFSDK_Annot* pAnnot)
17 : CFFL_FormFiller(pApp, pAnnot), m_pFontMap(NULL) { 17 : CFFL_FormFiller(pApp, pAnnot), m_pFontMap(NULL) {
18 m_State.nIndex = 0; 18 m_State.nIndex = 0;
19 m_State.nStart = 0; 19 m_State.nStart = 0;
20 m_State.nEnd = 0; 20 m_State.nEnd = 0;
21 } 21 }
22 22
23 CFFL_ComboBox::~CFFL_ComboBox() { 23 CFFL_ComboBox::~CFFL_ComboBox() {
24 for (auto& it : m_Maps) {
Tom Sepez 2016/01/06 19:58:25 nit: const auto?
Lei Zhang 2016/01/06 22:08:38 Done.
25 CPWL_Wnd* pWnd = it.second;
Tom Sepez 2016/01/06 19:58:26 nit: local not needed.
Lei Zhang 2016/01/06 22:08:38 Done.
26 pWnd->InvalidateFocusHandler(this);
27 }
24 delete m_pFontMap; 28 delete m_pFontMap;
25 } 29 }
26 30
27 PWL_CREATEPARAM CFFL_ComboBox::GetCreateParam() { 31 PWL_CREATEPARAM CFFL_ComboBox::GetCreateParam() {
28 PWL_CREATEPARAM cp = CFFL_FormFiller::GetCreateParam(); 32 PWL_CREATEPARAM cp = CFFL_FormFiller::GetCreateParam();
29 33
30 int nFlags = m_pWidget->GetFieldFlags(); 34 int nFlags = m_pWidget->GetFieldFlags();
31 if (nFlags & FIELDFLAG_EDIT) { 35 if (nFlags & FIELDFLAG_EDIT) {
32 cp.dwFlags |= PCBS_ALLOWCUSTOMTEXT; 36 cp.dwFlags |= PCBS_ALLOWCUSTOMTEXT;
33 } 37 }
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 if (nExport >= 0) { 284 if (nExport >= 0) {
281 if (CPDF_FormField* pFormField = m_pWidget->GetFormField()) { 285 if (CPDF_FormField* pFormField = m_pWidget->GetFormField()) {
282 swRet = pFormField->GetOptionValue(nExport); 286 swRet = pFormField->GetOptionValue(nExport);
283 if (swRet.IsEmpty()) 287 if (swRet.IsEmpty())
284 swRet = pFormField->GetOptionLabel(nExport); 288 swRet = pFormField->GetOptionLabel(nExport);
285 } 289 }
286 } 290 }
287 291
288 return swRet; 292 return swRet;
289 } 293 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698