Issue 1564583004: Merge to XFA: Return unique_ptrs from test_support functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1564583004: Merge to XFA: Return unique_ptrs from test_support functions (Closed)

Created:
4 years, 11 months ago by Tom Sepez

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Return unique_ptrs from test_support functions Orignal Review URL: https://codereview.chromium.org/1563513002 . (cherry picked from commit aa326bd6b169dc1b5b9b83048c71799799ab34c6) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0aa3531a87dde44ffd90416f6d621b1828edaf22

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -44 lines)			Patch
M	fpdfsdk/src/fpdfdoc_embeddertest.cpp	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	fpdfsdk/src/fpdftext_embeddertest.cpp	View	5 chunks	+16 lines, -17 lines	0 comments	Download
M	samples/pdfium_test.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	testing/embedder_test.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	testing/embedder_test.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	testing/test_support.h	View	2 chunks	+16 lines, -4 lines	0 comments	Download
M	testing/test_support.cpp	View	4 chunks	+11 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 0aa3531a87dde44ffd90416f6d621b1828edaf22 (presubmit successful).

4 years, 11 months ago (2016-01-06 18:16:37 UTC) #3

Message was sent while issue was closed.

lgtm