Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1563513002: Return unique_ptrs from test_support functions (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : namespace pdfium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -44 lines) Patch
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 2 chunks +6 lines, -8 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 1 5 chunks +16 lines, -17 lines 0 comments Download
M samples/pdfium_test.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M testing/embedder_test.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M testing/embedder_test.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M testing/test_support.h View 1 2 chunks +16 lines, -4 lines 0 comments Download
M testing/test_support.cpp View 1 4 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review.
4 years, 11 months ago (2016-01-05 18:58:26 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-06 01:41:33 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-06 18:06:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aa326bd6b169dc1b5b9b83048c71799799ab34c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698