Move encoding module to oilpan

Move encoding module to oilpan

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166626

[haraken, 2014-02-06 04:31:11]

PTAL

[haraken, 2014-02-06 04:33:41]

On 2014/02/06 04:31:11, haraken wrote:
> PTAL

Just a moment. A couple of encoding tests are still failing. Looking.

[haraken, 2014-02-06 05:35:28]

Fixed the test failure. PTAL.

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/code_generator_v8.pm:2936: my $refPtrType =
IsGarbageCollectedType($interfaceName) ? "RefPtrWillBeRawPtr<$implClassName>" :
"RefPtr<$implClassName>";

Probably we need to implement a good helper method to convert an interface name
to a proper pointer type. Let me do that when introducing real types (probably
in the new Python compiler).

[tkent, 2014-02-06 05:44:52]

lgtm

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/code_generator_v8.pm:2936: my $refPtrType =
IsGarbageCollectedType($interfaceName) ? "RefPtrWillBeRawPtr<$implClassName>" :
"RefPtr<$implClassName>";

This change looks like we need to introduce another IDL attribute,
WillBeGarbageCollected, in addition to GarbageCollected.

[haraken, 2014-02-06 06:17:46]

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/code_generator_v8.pm:2936: my $refPtrType =
IsGarbageCollectedType($interfaceName) ? "RefPtrWillBeRawPtr<$implClassName>" :
"RefPtr<$implClassName>";
On 2014/02/06 05:44:52, tkent wrote:
> 
> This change looks like we need to introduce another IDL attribute,
> WillBeGarbageCollected, in addition to GarbageCollected.

Yeah, agreed. I'll rename [GarbageCollected] to [WillBeGarbageCollected] in a
follow-up CL.

[haraken, 2014-02-06 06:17:53]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-06 06:18:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/156453002/50001

[Mads Ager (chromium), 2014-02-06 09:38:32]

lgtm

[wibling-chromium, 2014-02-06 09:49:59]

lgtm

[zerny-chromium, 2014-02-06 10:23:08]

lgtm with a qq

https://codereview.chromium.org/156453002/diff/50001/Source/modules/encoding/...
File Source/modules/encoding/TextDecoder.h (left):

https://codereview.chromium.org/156453002/diff/50001/Source/modules/encoding/...
Source/modules/encoding/TextDecoder.h:56: using RefCounted<TextDecoder>::deref;
QQ: Should these not be behind an #if flag? Or were the unneeded on trunk?

https://codereview.chromium.org/156453002/diff/50001/Source/modules/encoding/...
File Source/modules/encoding/TextEncoder.h (left):

https://codereview.chromium.org/156453002/diff/50001/Source/modules/encoding/...
Source/modules/encoding/TextEncoder.h:56: using RefCounted<TextEncoder>::deref;
ditto

[haraken, 2014-02-06 11:04:22]

>
https://codereview.chromium.org/156453002/diff/50001/Source/modules/encoding/...
> Source/modules/encoding/TextDecoder.h:56: using
RefCounted<TextDecoder>::deref;
> QQ: Should these not be behind an #if flag? Or were the unneeded on trunk?

I think these were unneeded on trunk :)

[haraken, 2014-02-06 11:04:33]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-06 11:04:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/156453002/50001

[commit-bot: I haz the power, 2014-02-06 12:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 12:54:21]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[haraken, 2014-02-06 12:55:02]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-06 12:55:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/156453002/50001

[commit-bot: I haz the power, 2014-02-06 17:44:37]

Change committed as 166626

[Nils Barth (inactive), 2014-02-07 00:59:24]

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/156453002/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/code_generator_v8.pm:2936: my $refPtrType =
IsGarbageCollectedType($interfaceName) ? "RefPtrWillBeRawPtr<$implClassName>" :
"RefPtr<$implClassName>";
On 2014/02/06 05:35:28, haraken wrote:
> Probably we need to implement a good helper method to convert an interface
name
> to a proper pointer type. Let me do that when introducing real types (probably
> in the new Python compiler).

That's already handled as part of v8_types.cpp_type;
interface types are handled at the end (from l. 288; code search not yet up to
date):
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

If we need something for interfaces specifically, we can factor this out.

I've also added |pass_ref_ptr| and |ref_ptr| to template contents,
so we can easily use these throughout the templates in:
IDL compiler: sync Python to r166626
https://codereview.chromium.org/139653005/

[Nils Barth (inactive), 2014-02-07 01:00:25]

Python side in:
IDL compiler: sync Python to r166626
https://codereview.chromium.org/139653005/

[abarth-chromium, 2014-02-07 16:38:21]

A revert of this CL has been created in
https://codereview.chromium.org/157623002/ by abarth@chromium.org.

The reason for reverting is: Caused
http/tests/workers/terminate-during-sync-operation.html to crash.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40....

[abarth-chromium, 2014-02-07 16:40:02]

Actually looks like https://codereview.chromium.org/152513006 is the bad CL.