Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 152513006: Do not scan the active part of the stack in oilpan conservative garbage collections. (Closed)

Created:
6 years, 10 months ago by Mads Ager (chromium)
Modified:
6 years, 10 months ago
CC:
blink-reviews, haraken, Mads Ager (chromium)
Visibility:
Public.

Description

Do not scan the active part of the stack in oilpan conservative garbage collections. If threads are allowed to continue after safepointing there is a stack marker. We should stop stack scanning at the marker in that case. If there is no marker the thread whose thread we are iterating will be blocked and we should scan all the way to the recorded end stack pointer. R=vegorov@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/heap/ThreadState.cpp View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mads Ager (chromium)
6 years, 10 months ago (2014-02-06 14:41:10 UTC) #1
haraken
LGTM.
6 years, 10 months ago (2014-02-06 14:46:17 UTC) #2
wibling-chromium
lgtm
6 years, 10 months ago (2014-02-06 14:49:53 UTC) #3
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 10 months ago (2014-02-06 15:41:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/152513006/1
6 years, 10 months ago (2014-02-06 15:41:56 UTC) #5
Vyacheslav Egorov (Chromium)
lgtm
6 years, 10 months ago (2014-02-06 15:57:38 UTC) #6
commit-bot: I haz the power
Change committed as 166634
6 years, 10 months ago (2014-02-06 17:57:47 UTC) #7
abarth-chromium
6 years, 10 months ago (2014-02-07 16:40:36 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/157593004/ by abarth@chromium.org.

The reason for reverting is: Caused
http/tests/workers/terminate-during-sync-operation.html to crash. 

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...
.

Powered by Google App Engine
This is Rietveld 408576698