Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Issue 1564233005: Make cc::DrawingDisplayItem hold a const SkPicture. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make cc::DrawingDisplayItem hold a const SkPicture. This lets us remove const_cast<SkPicture*> from callers (i.e. Blink) which hold SkPicture through const pointers. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7994711ab6906f943da80049d13868530c07be1a Cr-Commit-Position: refs/heads/master@{#368444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M cc/blink/web_display_item_list_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/playback/drawing_display_item.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/playback/drawing_display_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jbroman
Any reason this holds onto a non-const SkPicture? I was about to write another const_cast ...
4 years, 11 months ago (2016-01-08 20:27:47 UTC) #4
danakj
LGTM
4 years, 11 months ago (2016-01-08 20:51:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564233005/1
4 years, 11 months ago (2016-01-08 20:55:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 22:07:29 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 22:08:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7994711ab6906f943da80049d13868530c07be1a
Cr-Commit-Position: refs/heads/master@{#368444}

Powered by Google App Engine
This is Rietveld 408576698