cc/playback/drawing_display_item.h - Issue 1564233005: Make cc::DrawingDisplayItem hold a const SkPicture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/playback/drawing_display_item.h

Issue 1564233005: Make cc::DrawingDisplayItem hold a const SkPicture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/playback/drawing_display_item.h

diff --git a/cc/playback/drawing_display_item.h b/cc/playback/drawing_display_item.h

index 9e8f1103facb3b4247c91f22db7efda70b5add6a..225bda415c6154d99a2e569249c1d39dec1a1926 100644

--- a/cc/playback/drawing_display_item.h

+++ b/cc/playback/drawing_display_item.h

@@ -21,7 +21,7 @@ namespace cc {

class CC_EXPORT DrawingDisplayItem : public DisplayItem {

public:

DrawingDisplayItem();

- explicit DrawingDisplayItem(skia::RefPtr<SkPicture> picture);

+ explicit DrawingDisplayItem(skia::RefPtr<const SkPicture> picture);

explicit DrawingDisplayItem(const proto::DisplayItem& proto);

explicit DrawingDisplayItem(const DrawingDisplayItem& item);

~DrawingDisplayItem() override;

@@ -40,9 +40,9 @@ class CC_EXPORT DrawingDisplayItem : public DisplayItem {

void CloneTo(DrawingDisplayItem* item) const;

private:

- void SetNew(skia::RefPtr<SkPicture> picture);

+ void SetNew(skia::RefPtr<const SkPicture> picture);

- skia::RefPtr<SkPicture> picture_;

+ skia::RefPtr<const SkPicture> picture_;

};

} // namespace cc

« no previous file with comments | « cc/blink/web_display_item_list_impl.cc ('k') | cc/playback/drawing_display_item.cc » ('j') | no next file with comments »