Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1563853002: Revert of Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController for aura A.. (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
Reviewers:
mfomitchev, Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, bondd+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController for aura Android (patchset #2 id:40001 of https://codereview.chromium.org/1422533008/ ) Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Original issue's description: > Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController for aura Android > > For aura Android, AutofillPopupViewViews will be used. And > in its implementation, AutofillPopupController::GetValueFontListForRow > and AutofillPopupController::GetLabelFontList were used. > The two functions were disabled for Android. And the reason > was gfx::GetStringWidth is not implemented for Android. But > they are implemented for aura. So this CL enables them for > aura Android > > BUG=507792 > > Committed: https://crrev.com/4c18758f292ffe08cec1da9642ca896484851b7f > Cr-Commit-Position: refs/heads/master@{#360127} TBR=mfomitchev@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507792 Committed: https://crrev.com/0b01e87c69ecb860d6ce9ec298f4124e765d0465 Cr-Commit-Position: refs/heads/master@{#367822}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller_impl.h View 4 chunks +4 lines, -4 lines 1 comment Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M components/resources/autofill_scaled_resources.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
bshe
Created Revert of Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController for aura Android
4 years, 11 months ago (2016-01-06 14:59:30 UTC) #1
mfomitchev
https://codereview.chromium.org/1563853002/diff/1/chrome/browser/ui/autofill/autofill_popup_controller_impl.h File chrome/browser/ui/autofill/autofill_popup_controller_impl.h (right): https://codereview.chromium.org/1563853002/diff/1/chrome/browser/ui/autofill/autofill_popup_controller_impl.h#newcode93 chrome/browser/ui/autofill/autofill_popup_controller_impl.h:93: #if !defined(OS_ANDROID) Would you mind changing these to use ...
4 years, 11 months ago (2016-01-06 19:10:14 UTC) #3
bshe
4 years, 11 months ago (2016-01-06 19:55:19 UTC) #4
Message was sent while issue was closed.
On 2016/01/06 19:10:14, mfomitchev wrote:
>
https://codereview.chromium.org/1563853002/diff/1/chrome/browser/ui/autofill/...
> File chrome/browser/ui/autofill/autofill_popup_controller_impl.h (right):
> 
>
https://codereview.chromium.org/1563853002/diff/1/chrome/browser/ui/autofill/...
> chrome/browser/ui/autofill/autofill_popup_controller_impl.h:93: #if
> !defined(OS_ANDROID)
> Would you mind changing these to use ANDROID_JAVA_UI instead? I think that
would
> be more consistent with what we are now doing elsewhere.

Make sense. I will do it in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698