Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2922)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 1563853002: Revert of Enable GetValueFontListForRow and GetLabelFontList in AutofillPopupController for aura A.. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index 1827dc7e61860f056916e42d9824cab8650e7448..857811f3111d7d0ad38e388e9466d3169a09d59d 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -40,7 +40,7 @@
// The vertical height of a separator in pixels.
const size_t kSeparatorHeight = 1;
-#if !defined(OS_ANDROID) || defined(USE_AURA)
+#if !defined(OS_ANDROID)
// Size difference between name and label in pixels.
const int kLabelFontSizeDelta = -2;
@@ -62,7 +62,7 @@
{ "jcbCC", IDR_AUTOFILL_CC_GENERIC },
{ "masterCardCC", IDR_AUTOFILL_CC_MASTERCARD },
{ "visaCC", IDR_AUTOFILL_CC_VISA },
-#if defined(OS_ANDROID) && !defined(USE_AURA)
+#if defined(OS_ANDROID)
{ "scanCreditCardIcon", IDR_AUTOFILL_CC_SCAN_NEW },
{ "settings", IDR_AUTOFILL_SETTINGS },
#endif
@@ -113,7 +113,7 @@
controller_common_->SetKeyPressCallback(
base::Bind(&AutofillPopupControllerImpl::HandleKeyPressEvent,
base::Unretained(this)));
-#if !defined(OS_ANDROID) || defined(USE_AURA)
+#if !defined(OS_ANDROID)
label_font_list_ = value_font_list_.DeriveWithSizeDelta(kLabelFontSizeDelta);
title_font_list_ = value_font_list_.DeriveWithStyle(gfx::Font::BOLD);
#if defined(OS_MACOSX)
@@ -133,7 +133,7 @@
DCHECK_EQ(suggestions_.size(), elided_values_.size());
DCHECK_EQ(suggestions_.size(), elided_labels_.size());
-#if !defined(OS_ANDROID) || defined(USE_AURA)
+#if !defined(OS_ANDROID)
// Android displays the long text with ellipsis using the view attributes.
UpdatePopupBounds();
@@ -310,7 +310,7 @@
}
void AutofillPopupControllerImpl::UpdateBoundsAndRedrawPopup() {
-#if !defined(OS_ANDROID) || defined(USE_AURA)
+#if !defined(OS_ANDROID)
// TODO(csharp): Since UpdatePopupBounds can change the position of the popup,
// the popup could end up jumping from above the element to below it.
// It is unclear if it is better to keep the popup where it was, or if it
@@ -359,10 +359,10 @@
}
}
-#if defined(OS_ANDROID) && !defined(USE_AURA)
+#if defined(OS_ANDROID)
if (result == IDR_AUTOFILL_CC_SCAN_NEW && IsKeyboardAccessoryEnabled())
result = IDR_AUTOFILL_CC_SCAN_NEW_KEYBOARD_ACCESSORY;
-#endif
+#endif // OS_ANDROID
return result;
}
@@ -460,7 +460,7 @@
return true;
}
-#if !defined(OS_ANDROID) || defined(USE_AURA)
+#if !defined(OS_ANDROID)
const gfx::FontList& AutofillPopupControllerImpl::GetValueFontListForRow(
size_t index) const {
if (suggestions_[index].frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE)
@@ -603,7 +603,7 @@
view_->InvalidateRow(row);
}
-#if !defined(OS_ANDROID) || defined(USE_AURA)
+#if !defined(OS_ANDROID)
int AutofillPopupControllerImpl::GetDesiredPopupWidth() const {
int popup_width = controller_common_->RoundedElementBounds().width();
for (size_t i = 0; i < GetLineCount(); ++i) {
@@ -657,7 +657,7 @@
popup_bounds_ = controller_common_->GetPopupBounds(popup_width, popup_height);
}
-#endif
+#endif // !defined(OS_ANDROID)
WeakPtr<AutofillPopupControllerImpl> AutofillPopupControllerImpl::GetWeakPtr() {
return weak_ptr_factory_.GetWeakPtr();

Powered by Google App Engine
This is Rietveld 408576698