Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1563543002: Clarify docs on GN rebase_path. (Closed)

Created:
4 years, 11 months ago by brettw
Modified:
4 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify docs on GN rebase_path. A question came up in a code review, so this adds more explicit documentation and hints for paths ending (or not) in slashes. Committed: https://crrev.com/e3b32676059d25162cd07201bbd33dfec3c60daf Cr-Commit-Position: refs/heads/master@{#367623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/gn/function_rebase_path.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
4 years, 11 months ago (2016-01-05 19:24:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563543002/1
4 years, 11 months ago (2016-01-05 19:26:31 UTC) #4
agrieve
On 2016/01/05 19:26:31, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 11 months ago (2016-01-05 19:42:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 19:51:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563543002/1
4 years, 11 months ago (2016-01-05 20:03:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 20:11:05 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 20:12:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3b32676059d25162cd07201bbd33dfec3c60daf
Cr-Commit-Position: refs/heads/master@{#367623}

Powered by Google App Engine
This is Rietveld 408576698