Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1563483003: Merge to XFA: Add embedder test for fpdfsave.cpp and bug 342 (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add embedder test for fpdfsave.cpp and bug 342 Original Review URL: https://codereview.chromium.org/1556033002 . (cherry picked from commit 603533fb0e5968923d67c1d8f2e00a640f41b5e5) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9eb811f7884db1ce0c145d2f90fa512283d7599b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A fpdfsdk/src/fpdfsave_embeddertest.cpp View 1 chunk +72 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, automatic.
4 years, 11 months ago (2016-01-05 22:19:44 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 9eb811f7884db1ce0c145d2f90fa512283d7599b (presubmit successful).
4 years, 11 months ago (2016-01-05 22:48:35 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-05 22:54:23 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698