Add embedder test for fpdfsave.cpp and bug 342

Add embedder test for fpdfsave.cpp and bug 342

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/603533fb0e5968923d67c1d8f2e00a640f41b5e5

[Tom Sepez, 2016-01-04 17:43:56]

Lei, quick test for the issue fixed by jun over vacation.

[Lei Zhang, 2016-01-04 19:32:48]

I have another CL here: https://codereview.chromium.org/1546063002/

Maybe wait for that to land and then add to it?

[Tom Sepez, 2016-01-05 21:16:16]

On 2016/01/04 19:32:48, Lei Zhang wrote:
> I have another CL here: https://codereview.chromium.org/1546063002/
> 
> Maybe wait for that to land and then add to it?

Alternatively, this could go first once we reach consensus on string tests vs.
re-loading test.

[Lei Zhang, 2016-01-05 22:12:14]

If you want to go first, then lgtm

https://codereview.chromium.org/1556033002/diff/20001/fpdfsdk/src/fpdfsave_em...
File fpdfsdk/src/fpdfsave_embeddertest.cpp (right):

https://codereview.chromium.org/1556033002/diff/20001/fpdfsdk/src/fpdfsave_em...
fpdfsdk/src/fpdfsave_embeddertest.cpp:16: static int
WriteBlockCallback(FPDF_FILEWRITE* pFileWrite,
This can be private.

https://codereview.chromium.org/1556033002/diff/20001/fpdfsdk/src/fpdfsave_em...
fpdfsdk/src/fpdfsave_embeddertest.cpp:36: std::string GetString() const { return
m_String; }
return const ref?

[Lei Zhang, 2016-01-05 22:16:21]

On 2016/01/05 21:16:16, Tom Sepez wrote:
> On 2016/01/04 19:32:48, Lei Zhang wrote:
> > I have another CL here: https://codereview.chromium.org/1546063002/
> > 
> > Maybe wait for that to land and then add to it?
> 
> Alternatively, this could go first once we reach consensus on string tests vs.
> re-loading test.

We can have both. String tests are simpler if you know what string(s) you are
(not) looking for, but reloading tests can potentially do more complicated
checks using existing APIs.

[Tom Sepez, 2016-01-05 22:16:58]

https://codereview.chromium.org/1556033002/diff/20001/fpdfsdk/src/fpdfsave_em...
File fpdfsdk/src/fpdfsave_embeddertest.cpp (right):

https://codereview.chromium.org/1556033002/diff/20001/fpdfsdk/src/fpdfsave_em...
fpdfsdk/src/fpdfsave_embeddertest.cpp:16: static int
WriteBlockCallback(FPDF_FILEWRITE* pFileWrite,
On 2016/01/05 22:12:14, Lei Zhang wrote:
> This can be private.

Done.

https://codereview.chromium.org/1556033002/diff/20001/fpdfsdk/src/fpdfsave_em...
fpdfsdk/src/fpdfsave_embeddertest.cpp:36: std::string GetString() const { return
m_String; }
On 2016/01/05 22:12:14, Lei Zhang wrote:
> return const ref?

Done.

[Tom Sepez, 2016-01-05 22:17:42]

Description was changed from

==========
Add embedder test for fpdfsave.cpp and bug 342

R=thestig@chromium.org
==========

to

==========
Add embedder test for fpdfsave.cpp and bug 342

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/603533fb0e5968923d67c1d8f2e00a640f41...
==========

[Tom Sepez, 2016-01-05 22:17:43]

Committed patchset #3 (id:40001) manually as
603533fb0e5968923d67c1d8f2e00a640f41b5e5 (presubmit successful).