Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1563443002: Move config texturability/renderability to config table (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@readpixformat
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : update #

Patch Set 4 : comment update #

Patch Set 5 : fix? #

Patch Set 6 : fix float on ES #

Patch Set 7 : oops #

Total comments: 1

Patch Set 8 : remove old tables #

Patch Set 9 : Attempted fix for iOS #

Patch Set 10 : dmflags hack #

Patch Set 11 : logging #

Patch Set 12 : again #

Patch Set 13 : remove debugging code #

Patch Set 14 : whitespace cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -422 lines) Patch
M include/gpu/GrCaps.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -13 lines 0 comments Download
M src/gpu/GrCaps.cpp View 1 2 3 4 5 6 7 2 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +10 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +21 lines, -26 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 16 chunks +316 lines, -373 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
bsalomon
PTAL
4 years, 11 months ago (2016-01-07 18:22:07 UTC) #4
jvanverth1
Just one question: https://codereview.chromium.org/1563443002/diff/120001/include/gpu/GrCaps.h File include/gpu/GrCaps.h (right): https://codereview.chromium.org/1563443002/diff/120001/include/gpu/GrCaps.h#newcode197 include/gpu/GrCaps.h:197: virtual bool isConfigTexturable(GrPixelConfig config) const = ...
4 years, 11 months ago (2016-01-07 18:49:38 UTC) #5
bsalomon
On 2016/01/07 18:49:38, jvanverth1 wrote: > Just one question: > > https://codereview.chromium.org/1563443002/diff/120001/include/gpu/GrCaps.h > File include/gpu/GrCaps.h ...
4 years, 11 months ago (2016-01-07 19:12:57 UTC) #6
jvanverth1
lgtm
4 years, 11 months ago (2016-01-07 19:49:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563443002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563443002/140001
4 years, 11 months ago (2016-01-07 20:40:02 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/32a3cd2f2860b15a842a6aa49e4e6a3bed04f949
4 years, 11 months ago (2016-01-07 21:00:14 UTC) #11
egdaniel
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/1569103003/ by egdaniel@google.com. ...
4 years, 11 months ago (2016-01-08 01:05:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563443002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563443002/260001
4 years, 11 months ago (2016-01-08 16:57:20 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 17:12:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #14 (id:260001) as
https://skia.googlesource.com/skia/+/41e4384ea0208631ab7847266c3369b17ed7fbf3

Powered by Google App Engine
This is Rietveld 408576698