Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1562843002: Revert of Introduces window_finder_android.cc (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
Reviewers:
mfomitchev, sky
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduces window_finder_android.cc Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Original issue's description: Introduces window_finder_android.cc Also adds dragged_window parameters to function GetLocalProcessWindowAtPoint BUG=507792 Committed: https://crrev.com/f6cef5f6e07fe5680de420ca0a1af9bb9bf3128f Cr-Commit-Position: refs/heads/master@{#358632} TBR=mfomitchev, sky NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507792 Committed: https://crrev.com/fd6ee646cd313f26234e2ddcfc0574089cf54c29 Cr-Commit-Position: refs/heads/master@{#367857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -135 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder.h View 1 chunk +5 lines, -6 lines 0 comments Download
D chrome/browser/ui/views/tabs/window_finder_android.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_ash.cc View 1 chunk +47 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_chromeos.cc View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/ui/views/tabs/window_finder_impl.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/ui/views/tabs/window_finder_impl.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_x11.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562843002/1
4 years, 11 months ago (2016-01-06 18:15:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 18:17:11 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 18:18:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd6ee646cd313f26234e2ddcfc0574089cf54c29
Cr-Commit-Position: refs/heads/master@{#367857}

Powered by Google App Engine
This is Rietveld 408576698