chromeos/network/network_sms_handler.h - Issue 1562593002: Fix potential crashes in NetworkHandler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_sms_handler.h

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test

Patch Set: Use NetworkStateHanlerObserver::IsShuttingDown instead Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_sms_handler.h

diff --git a/chromeos/network/network_sms_handler.h b/chromeos/network/network_sms_handler.h

index eb8ed88b0486c3b9b5ddb8330af7d097aed94b7b..1e987fc3f52c3935be12e4840bf7ebfaddeee969 100644

--- a/chromeos/network/network_sms_handler.h

+++ b/chromeos/network/network_sms_handler.h

@@ -90,7 +90,7 @@ class CHROMEOS_EXPORT NetworkSmsHandler : public ShillPropertyChangedObserver {

DBusMethodCallStatus call_status,

const base::DictionaryValue& properties);

- base::ObserverList<Observer> observers_;

+ base::ObserverList<Observer, true> observers_;

ScopedVector<NetworkSmsDeviceHandler> device_handlers_;

ScopedVector<base::DictionaryValue> received_messages_;

base::WeakPtrFactory<NetworkSmsHandler> weak_ptr_factory_;

@@ -98,6 +98,6 @@ class CHROMEOS_EXPORT NetworkSmsHandler : public ShillPropertyChangedObserver {

DISALLOW_COPY_AND_ASSIGN(NetworkSmsHandler);

};

-} // namespace

+} // namespace chromeos

#endif // CHROMEOS_NETWORK_NETWORK_SMS_HANDLER_H_