chrome/browser/chromeos/proxy_config_service_impl.h - Issue 1562593002: Fix potential crashes in NetworkHandler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl.h

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test

Patch Set: Use NetworkStateHanlerObserver::IsShuttingDown instead Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/proxy_config_service_impl.h

diff --git a/chrome/browser/chromeos/proxy_config_service_impl.h b/chrome/browser/chromeos/proxy_config_service_impl.h

index 3276fc6fc4ed509d645e7e415f5c736cd7049954..7c440326ea90c9d3e7b1f8d5d12c4a3c07b16d22 100644

--- a/chrome/browser/chromeos/proxy_config_service_impl.h

+++ b/chrome/browser/chromeos/proxy_config_service_impl.h

@@ -52,6 +52,7 @@ class ProxyConfigServiceImpl : public PrefProxyConfigTrackerImpl,

// NetworkStateHandlerObserver implementation.

void DefaultNetworkChanged(const NetworkState* network) override;

+ void IsShuttingDown() override;

oshima 2016/01/06 22:57:23 OnShuttingDown would be more consistent with the r

stevenjb 2016/01/06 23:28:31 That ship has kind of sailed, the method already e

oshima 2016/01/07 00:21:12 There is only one existing client right? https://

stevenjb 2016/01/07 17:07:47 Sure, I guess. I hate to mix re-factorings, but I'

protected:

friend class UIProxyConfigService;