chromeos/network/managed_network_configuration_handler_impl.h - Issue 1562593002: Fix potential crashes in NetworkHandler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/managed_network_configuration_handler_impl.h

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test

Patch Set: Use NetworkStateHanlerObserver::IsShuttingDown instead Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/managed_network_configuration_handler_impl.h

diff --git a/chromeos/network/managed_network_configuration_handler_impl.h b/chromeos/network/managed_network_configuration_handler_impl.h

index 76d6c2ef685b86988d6f201995518ccf79a684af..a6337f3d859313b3bfeee4970188fa333e34cbd3 100644

--- a/chromeos/network/managed_network_configuration_handler_impl.h

+++ b/chromeos/network/managed_network_configuration_handler_impl.h

@@ -215,7 +215,7 @@ class CHROMEOS_EXPORT ManagedNetworkConfigurationHandlerImpl

// associated set of GUIDs is empty.

UserToModifiedPoliciesMap queued_modified_policies_;

- base::ObserverList<NetworkPolicyObserver> observers_;

+ base::ObserverList<NetworkPolicyObserver, true> observers_;

// For Shill client callbacks

base::WeakPtrFactory<ManagedNetworkConfigurationHandlerImpl>