chromeos/network/network_sms_handler_unittest.cc - Issue 1562593002: Fix potential crashes in NetworkHandler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_sms_handler_unittest.cc

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test

Patch Set: Call NetworkStateHandler::Shutdown in destructor for unit tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_sms_handler_unittest.cc

diff --git a/chromeos/network/network_sms_handler_unittest.cc b/chromeos/network/network_sms_handler_unittest.cc

index 13b3b58c9a964ca84d17ef671bd23064f8e2564d..9ee2b0a15c8367a56e3d3cf93cfedbf19b02b044 100644

--- a/chromeos/network/network_sms_handler_unittest.cc

+++ b/chromeos/network/network_sms_handler_unittest.cc

@@ -81,6 +81,7 @@ class NetworkSmsHandlerTest : public testing::Test {

}

void TearDown() override {

+ network_sms_handler_->RemoveObserver(test_observer_.get());

network_sms_handler_.reset();

DBusThreadManager::Shutdown();

}