Fix potential crashes in NetworkHandler code

chrome/browser/chromeos/login/screens/network_screen.cc

Index: chrome/browser/chromeos/login/screens/network_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/network_screen.cc b/chrome/browser/chromeos/login/screens/network_screen.cc
index 4f8c8089c922a7c5e703a307a24f312f7ab0f782..b10458f7e48a088735d4caf0bb16da74ecbbe4c0 100644
--- a/chrome/browser/chromeos/login/screens/network_screen.cc
+++ b/chrome/browser/chromeos/login/screens/network_screen.cc
@@ -118,6 +118,9 @@ void NetworkScreen::OnViewDestroyed(NetworkView* view) {
   if (view_ == view) {
     view_ = nullptr;
     timezone_subscription_.reset();
+    // Ownership of NetworkScreen is complicated; ensure that we remove
+    // this as a NetworkStateHandler observer when the view is destroyed.

[oshima, 2016/01/06 22:57:23]

Are you going to refactor the code? If so, please file a bug for refactor and
add TODO.

[stevenjb, 2016/01/06 23:28:31]

I wasn't planning to, I'm not super familiar with the login code. I just looked
at it enough to determine that there wasn't a simple/straightforward to ensure
this class was destroyed before NetworkHandler. There shouldn't be any problems
with putting this call here, I just added the explanation in case someone does
decide to re-factor this.

[oshima, 2016/01/07 00:21:12]

Acknowledged.

+    UnsubscribeNetworkNotification();
   }
 }