chromeos/network/network_profile_handler.h - Issue 1562593002: Fix potential crashes in NetworkHandler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_profile_handler.h

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test

Patch Set: Call NetworkStateHandler::Shutdown in destructor for unit tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_profile_handler.h

diff --git a/chromeos/network/network_profile_handler.h b/chromeos/network/network_profile_handler.h

index 5015dd27ea6bbc0ca9ab06e0ac62eb0abb4539d4..f7c70c755a56d0d76a56c52c692419e4fa8d2c7c 100644

--- a/chromeos/network/network_profile_handler.h

+++ b/chromeos/network/network_profile_handler.h

@@ -81,7 +81,7 @@ class CHROMEOS_EXPORT NetworkProfileHandler

// properties are retrieved and the path is still in this set, a new profile

// object is created.

std::set<std::string> pending_profile_creations_;

- base::ObserverList<NetworkProfileObserver> observers_;

+ base::ObserverList<NetworkProfileObserver, true> observers_;

// For Shill client callbacks

base::WeakPtrFactory<NetworkProfileHandler> weak_ptr_factory_;