client/linux/minidump_writer/minidump_writer.cc - Issue 1562223002: Avoid comparing size_t to be < 0 on AArch64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/linux/minidump_writer/minidump_writer.cc

Issue 1562223002: Avoid comparing size_t to be < 0 on AArch64. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/linux/minidump_writer/minidump_writer.cc

diff --git a/client/linux/minidump_writer/minidump_writer.cc b/client/linux/minidump_writer/minidump_writer.cc

index 4b1e6f87843e4d6379384adb28c73d3cfb7889bb..932f146917c92de2e087f87a4f86da901d204800 100644

--- a/client/linux/minidump_writer/minidump_writer.cc

+++ b/client/linux/minidump_writer/minidump_writer.cc

@@ -1093,7 +1093,7 @@ class MinidumpWriter {

value_len = 0;

}

for (size_t i = 0;

- i < sizeof(cpu_features_entries)/

+ i != sizeof(cpu_features_entries)/

sizeof(cpu_features_entries[0]);

++i) {

const CpuFeaturesEntry* entry = &cpu_features_entries[i];

« no previous file with comments | « no previous file | no next file » | no next file with comments »