Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Side by Side Diff: client/linux/minidump_writer/minidump_writer.cc

Issue 1562223002: Avoid comparing size_t to be < 0 on AArch64. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010, Google Inc. 1 // Copyright (c) 2010, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 1075 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 const char* p = my_strchr(tag, ' '); 1086 const char* p = my_strchr(tag, ' ');
1087 if (p != NULL) { 1087 if (p != NULL) {
1088 tag_len = static_cast<size_t>(p - tag); 1088 tag_len = static_cast<size_t>(p - tag);
1089 value += tag_len + 1; 1089 value += tag_len + 1;
1090 value_len -= tag_len + 1; 1090 value_len -= tag_len + 1;
1091 } else { 1091 } else {
1092 tag_len = strlen(tag); 1092 tag_len = strlen(tag);
1093 value_len = 0; 1093 value_len = 0;
1094 } 1094 }
1095 for (size_t i = 0; 1095 for (size_t i = 0;
1096 i < sizeof(cpu_features_entries)/ 1096 i != sizeof(cpu_features_entries)/
1097 sizeof(cpu_features_entries[0]); 1097 sizeof(cpu_features_entries[0]);
1098 ++i) { 1098 ++i) {
1099 const CpuFeaturesEntry* entry = &cpu_features_entries[i]; 1099 const CpuFeaturesEntry* entry = &cpu_features_entries[i];
1100 if (tag_len == strlen(entry->tag) && 1100 if (tag_len == strlen(entry->tag) &&
1101 !memcmp(tag, entry->tag, tag_len)) { 1101 !memcmp(tag, entry->tag, tag_len)) {
1102 sys_info->cpu.arm_cpu_info.elf_hwcaps |= entry->hwcaps; 1102 sys_info->cpu.arm_cpu_info.elf_hwcaps |= entry->hwcaps;
1103 break; 1103 break;
1104 } 1104 }
1105 } 1105 }
1106 } 1106 }
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
1358 const MappingList& mappings, 1358 const MappingList& mappings,
1359 const AppMemoryList& appmem, 1359 const AppMemoryList& appmem,
1360 LinuxDumper* dumper) { 1360 LinuxDumper* dumper) {
1361 MinidumpWriter writer(filename, -1, NULL, mappings, appmem, dumper); 1361 MinidumpWriter writer(filename, -1, NULL, mappings, appmem, dumper);
1362 if (!writer.Init()) 1362 if (!writer.Init())
1363 return false; 1363 return false;
1364 return writer.Dump(); 1364 return writer.Dump();
1365 } 1365 }
1366 1366
1367 } // namespace google_breakpad 1367 } // namespace google_breakpad
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698