Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1562183002: ObjectPainter::paintAsStackingContext() (Closed)

Created:
4 years, 11 months ago by Xianzhu
Modified:
4 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, slimming-paint-reviews_chromium.org, svillar, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ObjectPainter::paintAsStackingContext() Was BlockPainter::paintAsInlineBlock(). Let other places having similar code call the new function. This is a preparation for further works for crbug.com/574938. BUG=574938 Committed: https://crrev.com/3d52bb54aaa5d39147adf27e02fa04d0abd2fbf7 Cr-Commit-Position: refs/heads/master@{#368109}

Patch Set 1 #

Patch Set 2 #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -95 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp View 1 2 1 chunk +20 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.h View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 2 3 chunks +5 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/paint/GridPainter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.h View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp View 1 2 3 chunks +24 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp View 1 2 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Xianzhu
4 years, 11 months ago (2016-01-07 00:45:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562183002/40001
4 years, 11 months ago (2016-01-07 00:57:04 UTC) #5
chrishtr
https://codereview.chromium.org/1562183002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.h File third_party/WebKit/Source/core/layout/LayoutBlock.h (right): https://codereview.chromium.org/1562183002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.h#newcode321 third_party/WebKit/Source/core/layout/LayoutBlock.h:321: // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved ...
4 years, 11 months ago (2016-01-07 01:51:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 03:09:47 UTC) #8
Xianzhu
https://codereview.chromium.org/1562183002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.h File third_party/WebKit/Source/core/layout/LayoutBlock.h (right): https://codereview.chromium.org/1562183002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.h#newcode321 third_party/WebKit/Source/core/layout/LayoutBlock.h:321: // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved ...
4 years, 11 months ago (2016-01-07 17:02:40 UTC) #9
chrishtr
lgtm
4 years, 11 months ago (2016-01-07 17:09:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562183002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562183002/80001
4 years, 11 months ago (2016-01-07 17:10:28 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 11 months ago (2016-01-07 18:36:50 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3d52bb54aaa5d39147adf27e02fa04d0abd2fbf7 Cr-Commit-Position: refs/heads/master@{#368109}
4 years, 11 months ago (2016-01-07 18:37:49 UTC) #15
Xianzhu
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.chromium.org/1569293003/ by wangxianzhu@chromium.org. ...
4 years, 11 months ago (2016-01-09 00:05:01 UTC) #16
Xianzhu
4 years, 11 months ago (2016-01-09 00:09:18 UTC) #17
Message was sent while issue was closed. 
On 2016/01/09 00:05:01, Xianzhu wrote:
> A revert of this CL (patchset #4 id:80001) has been created in
> https://codereview.chromium.org/1569293003/ by
mailto:wangxianzhu@chromium.org.
> 
> The reason for reverting is: Caused bug 575580
> 
> BUG=575580.

Aborted the revert. Will fix the bug with a small change instead.

Powered by Google App Engine
This is Rietveld 408576698