Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1562093002: Remove work from constructors to facilitate debugging. (Closed)

Created:
4 years, 11 months ago by herb_g
Modified:
4 years, 11 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : Use valid width and height. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M gm/blurroundrect.cpp View 1 2 3 chunks +13 lines, -18 lines 0 comments Download
M gm/composeshader.cpp View 1 4 chunks +10 lines, -15 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562093002/1
4 years, 11 months ago (2016-01-06 18:31:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/7467) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on ...
4 years, 11 months ago (2016-01-06 18:32:57 UTC) #7
herb_g
sync
4 years, 11 months ago (2016-01-06 19:45:21 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562093002/20001
4 years, 11 months ago (2016-01-06 19:45:51 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/5050)
4 years, 11 months ago (2016-01-06 19:54:02 UTC) #12
herb_g
Use valid width and height.
4 years, 11 months ago (2016-01-07 19:54:17 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562093002/40001
4 years, 11 months ago (2016-01-07 19:55:04 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 20:16:31 UTC) #17
herb_g
Ok. This CL looks to be ready. PTAL
4 years, 11 months ago (2016-01-07 20:24:13 UTC) #18
caryclark
lgtm
4 years, 11 months ago (2016-01-07 21:17:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562093002/40001
4 years, 11 months ago (2016-01-08 21:30:59 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 21:48:45 UTC) #23
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b10fe4941b08172378d3d1928959122f106ced37

Powered by Google App Engine
This is Rietveld 408576698