Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 1562013002: Fix the oilpan build break after r367789. (Closed)

Created:
3 years, 9 months ago by hayato
Modified:
3 years, 9 months ago
Reviewers:
tkent, sof, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the oilpan build break after r367789. See https://codereview.chromium.org/1530643003/#msg35 The CL did not use HeapVector nor HeapHashMap. BUG=531990 Committed: https://crrev.com/b7d9547b2d4c99fd541e74295c6e40213bf34094 Cr-Commit-Position: refs/heads/master@{#367812}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use raw pointer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
hayato
PTAL
3 years, 9 months ago (2016-01-06 08:30:01 UTC) #3
kochi
will defer to tkent-san for oilpan review.
3 years, 9 months ago (2016-01-06 08:39:34 UTC) #4
sof
lgtm Could you change the title to the shorter Fix the oilpan build break after ...
3 years, 9 months ago (2016-01-06 08:40:30 UTC) #6
kochi
On 2016/01/06 08:39:34, kochi wrote: > will defer to tkent-san for oilpan review. Probably the ...
3 years, 9 months ago (2016-01-06 08:40:32 UTC) #7
tkent
lgtm https://codereview.chromium.org/1562013002/diff/1/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp (right): https://codereview.chromium.org/1562013002/diff/1/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp#newcode31 third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:31: using Name2Slot = WillBeHeapHashMap<AtomicString, RefPtrWillBeMember<HTMLSlotElement>>; The original code ...
3 years, 9 months ago (2016-01-06 08:41:21 UTC) #9
hayato
Use raw pointer
3 years, 9 months ago (2016-01-06 08:51:48 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562013002/20001
3 years, 9 months ago (2016-01-06 08:52:09 UTC) #13
hayato
https://codereview.chromium.org/1562013002/diff/1/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp File third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp (right): https://codereview.chromium.org/1562013002/diff/1/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp#newcode31 third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:31: using Name2Slot = WillBeHeapHashMap<AtomicString, RefPtrWillBeMember<HTMLSlotElement>>; On 2016/01/06 08:41:21, tkent ...
3 years, 9 months ago (2016-01-06 08:55:51 UTC) #14
hayato
I also updated the description. Let me land the fix.
3 years, 9 months ago (2016-01-06 08:56:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562013002/20001
3 years, 9 months ago (2016-01-06 08:56:51 UTC) #19
sof
(almost there now, but please consider using NOTRY= for fixes that addresses tree breaks.)
3 years, 9 months ago (2016-01-06 09:33:00 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 9 months ago (2016-01-06 10:25:04 UTC) #23
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b7d9547b2d4c99fd541e74295c6e40213bf34094 Cr-Commit-Position: refs/heads/master@{#367812}
3 years, 9 months ago (2016-01-06 10:26:09 UTC) #25
hayato
3 years, 9 months ago (2016-01-06 10:37:35 UTC) #26
Message was sent while issue was closed.
On 2016/01/06 09:33:00, sof wrote:
> (almost there now, but please consider using NOTRY= for fixes that addresses
> tree breaks.)

Yeah, I leaned it. Thank you.
I did not think that Oilpan build break is a tree breaker.

Powered by Google App Engine
This is Rietveld 408576698