Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1561853002: Merge to XFA: Replace CPDF_SortObjNumArray with a std::set. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Replace CPDF_SortObjNumArray with a std::set. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1566553002 . (cherry picked from commit 6caae4d3c6815c5a1e12340734412a3bc7548652) Committed: https://pdfium.googlesource.com/pdfium/+/45856be7b6658aaf7fe943d9e0f285811e98b6a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -50 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +0 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 8 chunks +9 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR, clean merge.
4 years, 11 months ago (2016-01-06 00:55:56 UTC) #1
Tom Sepez
lgtm
4 years, 11 months ago (2016-01-06 00:57:19 UTC) #2
Lei Zhang
4 years, 11 months ago (2016-01-06 01:01:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45856be7b6658aaf7fe943d9e0f285811e98b6a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698